From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TivqT-0002sO-2b for qemu-devel@nongnu.org; Wed, 12 Dec 2012 18:36:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TivqQ-0007aJ-Ub for qemu-devel@nongnu.org; Wed, 12 Dec 2012 18:36:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:65242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TivqQ-0007a6-NJ for qemu-devel@nongnu.org; Wed, 12 Dec 2012 18:36:06 -0500 Date: Thu, 13 Dec 2012 00:36:02 +0100 From: Igor Mammedov Message-ID: <20121213003602.2a631986@thinkpad.mammed.net> In-Reply-To: <1355350946-28010-3-git-send-email-ehabkost@redhat.com> References: <1355350946-28010-1-git-send-email-ehabkost@redhat.com> <1355350946-28010-3-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] target-i386/cpu.c: coding style fix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Andreas =?UTF-8?B?RsOkcmJlcg==?= On Wed, 12 Dec 2012 20:22:25 -0200 Eduardo Habkost wrote: While at it, could you remove the last as well? > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index a2ee8bb..25f7500 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -1865,10 +1865,11 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count, > /* XXX: The physical address space is limited to 42 bits in exec.c. */ > *eax = 0x00003028; /* 48 bits virtual, 40 bits physical */ > } else { > - if (env->cpuid_features & CPUID_PSE36) > + if (env->cpuid_features & CPUID_PSE36) { > *eax = 0x00000024; /* 36 bits physical */ > - else > + } else { > *eax = 0x00000020; /* 32 bits physical */ > + } > } > *ebx = 0; > *ecx = 0; > -- > 1.7.11.7 > -- Regards, Igor