From: Amit Shah <amit.shah@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Alon Levy <alevy@redhat.com>, qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/3] chardev/spice: fix missing spice mouse after migration
Date: Fri, 14 Dec 2012 09:40:07 +0530 [thread overview]
Message-ID: <20121214041007.GC12267@amit.redhat.com> (raw)
In-Reply-To: <87k3sm112z.fsf@codemonkey.ws>
On (Thu) 13 Dec 2012 [08:25:08], Anthony Liguori wrote:
> Amit Shah <amit.shah@redhat.com> writes:
>
> > On (Wed) 28 Nov 2012 [11:05:37], Alon Levy wrote:
> >> Adds a new char device backend callback to check connectedness, implemented
> >> for virtio console, and used by spice-char-dev in post migration.
> >>
> >> Is using NULL for DeviceState the intention for non device vmstates? It works
> >> fine in practice.
> >
> > Any more opinions / reviews on this series? Anthony?
>
> Spice should save its state and not rely on the chardev layer to replay
> it.
>
> I thought this was already pointed out in this thread?
Indeed. Alon, just adding save/load to spice-qemu-char.c doesn't work
for you?
Amit
next prev parent reply other threads:[~2012-12-14 4:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-25 13:39 [Qemu-devel] [PATCH] hw/virtio-serial-bus: replay guest open on destination Alon Levy
2012-11-27 12:48 ` Amit Shah
2012-11-27 14:10 ` Markus Armbruster
2012-11-27 14:34 ` Amit Shah
2012-11-27 19:03 ` Anthony Liguori
2012-11-28 9:05 ` [Qemu-devel] [PATCH 0/3] chardev/spice: fix missing spice mouse after migration Alon Levy
2012-11-28 9:05 ` [Qemu-devel] [PATCH 1/3] virtio-serial: add virtio_serial_guest_connected Alon Levy
2012-11-28 9:05 ` [Qemu-devel] [PATCH 2/3] qemu-char: add qemu_chr_be_connected Alon Levy
2012-11-28 9:42 ` Markus Armbruster
2012-11-28 9:05 ` [Qemu-devel] [PATCH 3/3] spice-qemu-char: register interface on post load Alon Levy
2012-11-28 9:46 ` Markus Armbruster
2012-11-28 9:51 ` Alon Levy
2012-11-28 11:59 ` Markus Armbruster
2012-11-28 12:16 ` Alon Levy
2012-11-29 13:08 ` Amit Shah
2012-12-13 10:54 ` [Qemu-devel] [PATCH 0/3] chardev/spice: fix missing spice mouse after migration Amit Shah
2012-12-13 14:25 ` Anthony Liguori
2012-12-14 4:10 ` Amit Shah [this message]
2012-12-23 21:35 ` [Qemu-devel] [PATCH] spice-qemu-char: register interface on post load Alon Levy
2012-12-24 7:39 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121214041007.GC12267@amit.redhat.com \
--to=amit.shah@redhat.com \
--cc=alevy@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).