From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjMbh-0001u0-I4 for qemu-devel@nongnu.org; Thu, 13 Dec 2012 23:10:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjMbg-00071M-Mb for qemu-devel@nongnu.org; Thu, 13 Dec 2012 23:10:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29555) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjMbg-00070q-ER for qemu-devel@nongnu.org; Thu, 13 Dec 2012 23:10:40 -0500 Date: Fri, 14 Dec 2012 09:40:07 +0530 From: Amit Shah Message-ID: <20121214041007.GC12267@amit.redhat.com> References: <87lidm6f7p.fsf@codemonkey.ws> <1354093540-22583-1-git-send-email-alevy@redhat.com> <20121213105423.GA6857@amit.redhat.com> <87k3sm112z.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k3sm112z.fsf@codemonkey.ws> Subject: Re: [Qemu-devel] [PATCH 0/3] chardev/spice: fix missing spice mouse after migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Alon Levy , qemu-devel@nongnu.org, armbru@redhat.com On (Thu) 13 Dec 2012 [08:25:08], Anthony Liguori wrote: > Amit Shah writes: > > > On (Wed) 28 Nov 2012 [11:05:37], Alon Levy wrote: > >> Adds a new char device backend callback to check connectedness, implemented > >> for virtio console, and used by spice-char-dev in post migration. > >> > >> Is using NULL for DeviceState the intention for non device vmstates? It works > >> fine in practice. > > > > Any more opinions / reviews on this series? Anthony? > > Spice should save its state and not rely on the chardev layer to replay > it. > > I thought this was already pointed out in this thread? Indeed. Alon, just adding save/load to spice-qemu-char.c doesn't work for you? Amit