From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjXqb-00070z-C1 for qemu-devel@nongnu.org; Fri, 14 Dec 2012 11:10:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjXqa-0002OZ-7h for qemu-devel@nongnu.org; Fri, 14 Dec 2012 11:10:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjXqa-0002OS-0G for qemu-devel@nongnu.org; Fri, 14 Dec 2012 11:10:48 -0500 Date: Fri, 14 Dec 2012 11:10:44 -0500 From: Jason Baron Message-ID: <20121214161044.GB1776@redhat.com> References: <31c4ba8885438636d2125723b19307ab99dca300.1355435056.git.jbaron@redhat.com> <50CA6DBC.1040700@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <50CA6DBC.1040700@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/3] qtest: extend qtest_qmp() to fill in the reply List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: kwolf@redhat.com, pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, quintela@redhat.com On Fri, Dec 14, 2012 at 01:07:24AM +0100, Andreas F=E4rber wrote: > Am 13.12.2012 23:02, schrieb Jason Baron: > > diff --git a/tests/Makefile b/tests/Makefile > > index b60f0fb..30a101d 100644 > > --- a/tests/Makefile > > +++ b/tests/Makefile > > @@ -74,10 +74,10 @@ tests/test-qmp-input-strict$(EXESUF): tests/test-= qmp-input-strict.o $(test-qapi- > > tests/test-qmp-commands$(EXESUF): tests/test-qmp-commands.o tests/te= st-qmp-marshal.o $(test-qapi-obj-y) > > tests/test-visitor-serialization$(EXESUF): tests/test-visitor-serial= ization.o $(test-qapi-obj-y) > > =20 > > -tests/rtc-test$(EXESUF): tests/rtc-test.o $(trace-obj-y) > > +tests/rtc-test$(EXESUF): tests/rtc-test.o $(trace-obj-y) qstring.o > > tests/m48t59-test$(EXESUF): tests/m48t59-test.o $(trace-obj-y) > > -tests/fdc-test$(EXESUF): tests/fdc-test.o tests/libqtest.o $(trace-o= bj-y) > > -tests/hd-geo-test$(EXESUF): tests/hd-geo-test.o tests/libqtest.o $(t= race-obj-y) > > +tests/fdc-test$(EXESUF): tests/fdc-test.o tests/libqtest.o $(trace-o= bj-y) qstring.o > > +tests/hd-geo-test$(EXESUF): tests/hd-geo-test.o tests/libqtest.o $(t= race-obj-y) qstring.o >=20 > Adding a dependency to every qtest is calling for a $(qtest-obj-y) to > administer that list in a central location. I am expecting the number o= f > tests to grow significantly over time. >=20 > Andreas >=20 ok, seems as though we can add $(test-qapi-obj-y) $(qom-obj-y), etc. to t= he qtest-obj-y target, to simplify things a bit. I'll re-post that as a separate patch. Thanks, -Jason