From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40990)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TkFLx-00064j-5s
	for qemu-devel@nongnu.org; Sun, 16 Dec 2012 09:38:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TkFLt-0001Gz-Q6
	for qemu-devel@nongnu.org; Sun, 16 Dec 2012 09:38:05 -0500
Received: from mx1.redhat.com ([209.132.183.28]:14186)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TkFLt-0001Gh-IZ
	for qemu-devel@nongnu.org; Sun, 16 Dec 2012 09:38:01 -0500
Date: Sun, 16 Dec 2012 16:41:09 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20121216144109.GA9993@redhat.com>
References: <20121213072606.GA833@redhat.com>
 <87fw39r8w6.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87fw39r8w6.fsf@codemonkey.ws>
Subject: Re: [Qemu-devel] [PULL] pci,net,misc infrastructure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: yamahata@valinux.co.jp, jbaron@redhat.com, qemu-devel@nongnu.org

On Thu, Dec 13, 2012 at 02:31:53PM -0600, Anthony Liguori wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> 
> > The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d:
> >
> >   Merge remote-tracking branch 'afaerber/qom-cpu' into staging (2012-12-10 08:35:15 -0600)
> >
> > are available in the git repository at:
> >
> >
> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony
> >
> > for you to fetch changes up to 5c1ad98d71923b83a530e5db4c2110564b84e11d:
> >
> >   pci_bus.h: tweak include guards (2012-12-12 23:41:04 +0200)
> 
> Doesn't build:
> 
>   CC    hw/apm.o
> /home/anthony/git/qemu/hw/apm.c:25:17: fatal error: pci.h: No such file or directory
> compilation terminated.
> 
> And there's really no good reason for this.  apm's part of target-i386
> so you couldn't have built this prior to doing a pull request.
> 
> Please setup your tree in buildbot and wait for a full run before
> sending a pull requests in the future.
> 
> Regards,
> 
> Anthony Liguori

Ugh.
I'm not sure but I think I see how this happened: I re-run make after
each commit, before the last one apm.c did find the header it depends
on, the last commit only removes the -I flag to find the header
but neither the header itself not the C file changed so it didn't
need to rebuild.

-- 
MST