From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33409)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1TkO9c-0007jA-Ex
	for qemu-devel@nongnu.org; Sun, 16 Dec 2012 19:01:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1TkO9b-000081-5U
	for qemu-devel@nongnu.org; Sun, 16 Dec 2012 19:01:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:51246)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1TkO9a-00007v-UP
	for qemu-devel@nongnu.org; Sun, 16 Dec 2012 19:01:55 -0500
Date: Sun, 16 Dec 2012 22:01:46 -0200
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20121217000146.GA8715@amt.cnet>
References: <20121214233957.GA19778@amt.cnet>
	<CAF3u54Cuede5oGLXHunzs9Qxt_fXLmqXO7EP6E+qbxzfNhMFfg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAF3u54Cuede5oGLXHunzs9Qxt_fXLmqXO7EP6E+qbxzfNhMFfg@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] fix dma.c MemoryRegion convertion
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Julien Grall <julien.grall@gmail.com>
Cc: Julien Grall <julien.grall@citrix.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Sat, Dec 15, 2012 at 01:45:38PM +0000, Julien Grall wrote:
> On Fri, Dec 14, 2012 at 11:39 PM, Marcelo Tosatti <mtosatti@redhat.com>=
 wrote:
> >
> >
> > The high byte of the ioport address is necessary to compute
> > the register address, see "82371AB PCI ISA IDE Xcelerator (PIIX4)"
> > document, eg:
> >
> > 4.2.1.1. DCOM=E2=80=94DMA Command Register (IO)
> > I/O Address: Channels 0=E2=80=933=E2=80=9408h; Channels 4=E2=80=937=E2=
=80=940D0h
> >
>=20
> I sent a patch on the mailing to resolve the problem yesterday
> (http://www.mail-archive.com/qemu-devel@nongnu.org/msg145242.html).
> Did it resolve your WinXp-32 installation? I just need to rework the co=
mment.

Yes it does.

> >
> > Also the size of the region is wrong.
>=20
> I don't think the size of the region is wrong. For the second DMA
> controller, the ioports are 0xD0 - 0xDE for the control registers.
> So the size is 16 not 8. It's the same for the channel registers.
>=20
> Thanks,

Correct, my patch is broken.

Thanks