From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkQBL-0001ns-Uz for qemu-devel@nongnu.org; Sun, 16 Dec 2012 21:11:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TkQBK-0004Em-D9 for qemu-devel@nongnu.org; Sun, 16 Dec 2012 21:11:51 -0500 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:45713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkQBJ-0004EW-SL for qemu-devel@nongnu.org; Sun, 16 Dec 2012 21:11:50 -0500 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 17 Dec 2012 12:05:16 +1000 Date: Mon, 17 Dec 2012 13:13:48 +1100 From: David Gibson Message-ID: <20121217021348.GB32451@truffula.fritz.box> References: <1354588937-27122-1-git-send-email-david@gibson.dropbear.id.au> <1354588937-27122-14-git-send-email-david@gibson.dropbear.id.au> <20121204031145.GG4293@truffula.fritz.box> <20121213131705.GX5217@truffula.fritz.box> <076A638B-C071-44B1-B845-C30018FDEBF4@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-ppc@nongnu.org, Mike Qiu , Alexander Graf , qemu-devel@nongnu.org On Thu, Dec 13, 2012 at 02:18:15PM +0000, Peter Maydell wrote: > On 13 December 2012 14:17, Peter Maydell wrote: > > On 13 December 2012 13:19, Alexander Graf wrote: > >> So because we don't call kvm_arch_init, the cap is 0 and thus we return 1? > > > > No, if we aren't CONFIG_KVM then that source file and version of > > the function aren't compiled at all. > > ...and 5 seconds after sending that I realised what you actually > meant. ignore me :-) And a bit later, so did I. I'll revise. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson