From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45564)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TkZKC-0004FE-JG
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 06:57:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TkZK7-0002Ws-U4
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 06:57:36 -0500
Received: from mx1.redhat.com ([209.132.183.28]:23823)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TkZK7-0002WY-Mt
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 06:57:31 -0500
Date: Mon, 17 Dec 2012 09:57:29 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20121217095729.057f7c1f@doriath.home>
In-Reply-To: <24E144B8C0207547AD09C467A8259F75578B48B1@lisa.maurer-it.com>
References: <1355500182-12743-1-git-send-email-lcapitulino@redhat.com>
	<1355500182-12743-2-git-send-email-lcapitulino@redhat.com>
	<24E144B8C0207547AD09C467A8259F75578B48B1@lisa.maurer-it.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dietmar Maurer <dietmar@proxmox.com>
Cc: "mdroth@linux.vnet.ibm.com" <mdroth@linux.vnet.ibm.com>, "aliguori@us.ibm.com" <aliguori@us.ibm.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "agl@us.ibm.com" <agl@us.ibm.com>

On Mon, 17 Dec 2012 10:13:40 +0000
Dietmar Maurer <dietmar@proxmox.com> wrote:

> > Next commit will re-enable balloon stats with a different interface, but this
> > old code conflicts with it. Let's drop it.
> 
> I don't really see any conflicts here?

query-balloon resets all stats to -1. So, if it's issued after the stats have
been polled all values are lost.

> > It's important to note that the QMP and HMP interfaces are also dropped by
> > this commit. That shouldn't be a problem though, because:
> > 
> >  1. All QMP fields are optional
> >  2. This has never been really used
> 
> Why don't we simply implement the missing parts - it's just a few lines of code.

For the reasons explained in my last email. We'd need at least two commands,
one for to enable polling/set time interval and also query-balloon-stats,
as adding this to query-balloon would mix semantics (ie. one field is always
there and the others have polling semantics).