From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47589)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TkZVt-0006Cv-4a
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 07:09:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TkZVp-0005id-3J
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 07:09:41 -0500
Received: from mx1.redhat.com ([209.132.183.28]:2296)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1TkZVo-0005h9-Qi
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 07:09:37 -0500
Date: Mon, 17 Dec 2012 10:09:36 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20121217100936.56a24ffd@doriath.home>
In-Reply-To: <1355723470.17969.19.camel@oc2826874472.ibm.com>
References: <1355723470.17969.19.camel@oc2826874472.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] QMP command implementation help
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Shraddha Kamat <sh2008ka@gmail.com>
Cc: Adam Litke <agl@us.ibm.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On Mon, 17 Dec 2012 11:21:10 +0530
Shraddha Kamat <sh2008ka@gmail.com> wrote:

> I am implementing couple of QMP commands to Qemu - so trying a 
> hello-world command first as shown here
> https://github.com/qemu/qemu/blob/master/docs/writing-qmp-commands.txt
> 
> Step 1 :
> ========
> Added to qapi-schema.json file this :
> { 'command': 'hello-world' }
> 
> Step 2:
> =======
> Added to qmp.c :
> 
> void qmp_hello_world(Error **errp)
> {
>     printf("Hello, world!\n");
> }
> 
> Step 3 :
> ========
> Added to qmp-commands.hx :
>    {
>         .name = "hello-world",
>         .args_type = "",
>         .mhandler.cmd_new = qmp_marshal_input_hello_world,
>    },
> 
> and build upstream Qemu-kvm : 

Shraddha, I've just followed the three steps above and things just worked
for me:

{
    "QMP": {
        "version": {
            "qemu": {
                "micro": 50, 
                "minor": 3, 
                "major": 1
            }, 
            "package": ""
        }, 
        "capabilities": [
        ]
    }
}
{ "execute": "qmp_capabilities" }
{
    "return": {
    }
}
{ "execute": "hello-world" }
{
    "return": {
    }
}

Patch below. There must something wrong with your tree. What's the qemu
version you're using?

diff --git a/qapi-schema.json b/qapi-schema.json
index 5dfa052..717d201 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3017,3 +3017,5 @@
 # Since: 1.3.0
 ##
 { 'command': 'nbd-server-stop' }
+
+{ 'command': 'hello-world' }
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 5c692d0..50db26e 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -2654,3 +2654,9 @@ EQMP
         .args_type  = "",
         .mhandler.cmd_new = qmp_marshal_input_query_target,
     },
+
+	{
+		.name = "hello-world",
+		.args_type = "",
+		.mhandler.cmd_new = qmp_marshal_input_hello_world,
+	},
diff --git a/qmp.c b/qmp.c
index e3a7f0b..e5bfc35 100644
--- a/qmp.c
+++ b/qmp.c
@@ -519,3 +519,8 @@ void qmp_add_client(const char *protocol, const char *fdname,
     error_setg(errp, "protocol '%s' is invalid", protocol);
     close(fd);
 }
+
+void qmp_hello_world(Error **errp)
+{
+    printf("Hello, world!\n");
+}