From: "Michael S. Tsirkin" <mst@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
yamahata@valinux.co.jp, jbaron@redhat.com, qemu-devel@nongnu.org,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PULL] pci,net,misc infrastructure
Date: Mon, 17 Dec 2012 13:19:01 +0200 [thread overview]
Message-ID: <20121217111901.GA19609@redhat.com> (raw)
In-Reply-To: <87k3shueog.fsf@blackfin.pond.sub.org>
On Mon, Dec 17, 2012 at 11:59:59AM +0100, Markus Armbruster wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
>
> > On Fri, Dec 14, 2012 at 09:37:17PM +0000, Blue Swirl wrote:
> >> Perhaps the use of '-' vs. '_' in file names could be unified while
> >> renaming. I think most new files use dash.
>
> Yes, please!
>
> > I can do this in a follow up patch but first let's put this rule in
> > coding style file. As it is more files use _ than -.
> > And I'm not sure what's the point of using dash, as opposed
> > to underscore: underscore seems more consistent.
>
> Actually, '-' is more common:
>
> $ git-ls-files | wc -l
> 2839
> $ git-ls-files | grep [-_] | wc -l
> 2150
> $ git-ls-files | grep _ | wc -l
> 1124
> $ git-ls-files | grep -- - | wc -l
> 1567
I think you counted target-XXX linux-user etc multiple times.
next prev parent reply other threads:[~2012-12-17 11:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 7:26 [Qemu-devel] [PULL] pci,net,misc infrastructure Michael S. Tsirkin
2012-12-13 20:31 ` Anthony Liguori
2012-12-16 14:41 ` Michael S. Tsirkin
2012-12-16 15:23 ` Michael S. Tsirkin
2012-12-16 21:10 ` Michael S. Tsirkin
2012-12-14 20:26 ` Blue Swirl
2012-12-14 21:37 ` Blue Swirl
2012-12-16 14:46 ` Michael S. Tsirkin
2012-12-17 10:59 ` Markus Armbruster
2012-12-17 11:19 ` Michael S. Tsirkin [this message]
2012-12-17 12:30 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121217111901.GA19609@redhat.com \
--to=mst@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=jbaron@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).