From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39168)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TkYji-0001S6-Kw
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 06:21:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TkYfq-0006JN-OT
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 06:19:54 -0500
Received: from mx1.redhat.com ([209.132.183.28]:34274)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TkYfq-0006JI-Ga
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 06:15:54 -0500
Date: Mon, 17 Dec 2012 13:19:01 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20121217111901.GA19609@redhat.com>
References: <20121213072606.GA833@redhat.com>
	<CAAu8pHvMesfOfc7-bCnN+nJvkeZcn1CRFDrVrVFnmoHMCvS4WQ@mail.gmail.com>
	<20121216144639.GB9993@redhat.com>
	<87k3shueog.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87k3shueog.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PULL] pci,net,misc infrastructure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, yamahata@valinux.co.jp, jbaron@redhat.com, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>

On Mon, Dec 17, 2012 at 11:59:59AM +0100, Markus Armbruster wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> 
> > On Fri, Dec 14, 2012 at 09:37:17PM +0000, Blue Swirl wrote:
> >> Perhaps the use of '-' vs. '_' in file names could be unified while
> >> renaming. I think most new files use dash.
> 
> Yes, please!
> 
> > I can do this in a follow up patch but first let's put this rule in
> > coding style file. As it is more files use _ than -.
> > And I'm not sure what's the point of using dash, as opposed
> > to underscore: underscore seems more consistent.
> 
> Actually, '-' is more common:
> 
> $ git-ls-files | wc -l
> 2839
> $ git-ls-files | grep [-_] | wc -l
> 2150
> $ git-ls-files | grep _ | wc -l
> 1124
> $ git-ls-files | grep -- - | wc -l
> 1567

I think you counted target-XXX linux-user etc multiple times.