qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: fred.konrad@greensocs.com
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com,
	e.voevodin@samsung.com, mark.burton@greensocs.com,
	qemu-devel@nongnu.org, stefanha@redhat.com,
	cornelia.huck@de.ibm.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring.
Date: Mon, 17 Dec 2012 17:45:08 +0200	[thread overview]
Message-ID: <20121217154508.GA28712@redhat.com> (raw)
In-Reply-To: <1354887155-32281-1-git-send-email-fred.konrad@greensocs.com>

On Fri, Dec 07, 2012 at 02:32:29PM +0100, fred.konrad@greensocs.com wrote:
> From: KONRAD Frederic <fred.konrad@greensocs.com>
> 
> You can clone that from here :
> git.greensocs.com/home/greensocs/git/qemu_virtio.git virtio_refactoring_v6
> 
> The problem with the last RFC v5 was that virtio-blk refactoring broke
> virtio-blk-pci device ( SEGFAULT ). So I modify this last step to fix that
> issue.
> 
> In order to not break anything, I think we have to refactor virtio-pci-blk in a
> next step then add a supplementary step which clean virtio-blk 
> ( eg : fix the cast ).
> 
> Does it make sense ?

I am yet to go over the patches but I did try to read
previous discussion and I am still puzzled about the motivation. One of
the previous messages mentioned this is to allow virtio-mmio.

Is the point to allow virtio-mmio?  Why can't virtio-mmio be just
another bus, like a pci bus, and another binding, like the virtio-pci
binding?

Is the issue that bindings are not devices?
I'm sending a patchset to use DeviceState as binding pointer -
will this address the issue?

If this was covered but I missed this I'll be thankful for
pointers if any.
Thanks,

-- 
MST

  parent reply	other threads:[~2012-12-17 15:42 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-07 13:32 [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring fred.konrad
2012-12-07 13:32 ` [Qemu-devel] [RFC PATCH v6 1/6] qdev : add a maximum device allowed field for the bus fred.konrad
2012-12-07 13:32 ` [Qemu-devel] [RFC PATCH v6 2/6] virtio-bus : Introduce virtio-bus fred.konrad
2012-12-07 13:32 ` [Qemu-devel] [RFC PATCH v6 3/6] virtio-pci-bus : Introduce virtio-pci-bus fred.konrad
2012-12-07 13:32 ` [Qemu-devel] [RFC PATCH v6 4/6] virtio-pci : Refactor virtio-pci device fred.konrad
2012-12-07 13:32 ` [Qemu-devel] [RFC PATCH v6 5/6] virtio-device : Refactor virtio-device fred.konrad
2012-12-07 13:32 ` [Qemu-devel] [RFC PATCH v6 6/6] virtio-blk : Add the virtio-blk device fred.konrad
2012-12-07 14:53   ` Peter Maydell
2012-12-17 15:45 ` Michael S. Tsirkin [this message]
2012-12-17 17:13   ` [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring KONRAD Frédéric
2012-12-17 20:46     ` Michael S. Tsirkin
2012-12-18 10:33   ` Peter Maydell
2012-12-18 11:01     ` Michael S. Tsirkin
2012-12-18 11:26       ` Peter Maydell
2012-12-18 11:50         ` Paolo Bonzini
2012-12-18 12:06           ` Peter Maydell
2012-12-18 13:10             ` Michael S. Tsirkin
2012-12-18 14:00               ` Peter Maydell
2012-12-18 14:36                 ` Paolo Bonzini
2012-12-18 14:56                   ` Peter Maydell
2012-12-18 14:59                     ` Paolo Bonzini
2012-12-18 15:42                       ` Michael S. Tsirkin
2012-12-18 15:14                     ` Michael S. Tsirkin
2012-12-18 14:51                 ` Michael S. Tsirkin
2012-12-18 11:30       ` KONRAD Frédéric
2012-12-18 13:21         ` Michael S. Tsirkin
2013-01-07 20:12           ` Anthony Liguori
2013-01-07 20:59             ` Michael S. Tsirkin
2013-01-07 21:24               ` Anthony Liguori
2013-01-07 21:37                 ` Michael S. Tsirkin
2013-01-07 21:51                   ` Anthony Liguori
2013-01-07 22:15                     ` Michael S. Tsirkin
2013-01-07 22:50                       ` Anthony Liguori
2013-01-08  6:46                         ` Michael S. Tsirkin
2013-01-07 22:16                 ` Michael S. Tsirkin
2013-01-07 19:58         ` Michael S. Tsirkin
2013-01-07 20:02           ` Peter Maydell
2013-01-07 20:49             ` Michael S. Tsirkin
2013-01-07 21:32               ` Anthony Liguori
2013-01-07 20:14           ` Anthony Liguori
2013-01-08  9:56           ` KONRAD Frédéric
2013-01-08 14:02             ` Michael S. Tsirkin
2013-01-08 14:27               ` KONRAD Frédéric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121217154508.GA28712@redhat.com \
    --to=mst@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=e.voevodin@samsung.com \
    --cc=fred.konrad@greensocs.com \
    --cc=mark.burton@greensocs.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).