From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53523)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TkhYx-0004xu-6E
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 15:45:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TkhYu-0006Bm-F7
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 15:45:23 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52484)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TkhYu-0006Bg-6B
	for qemu-devel@nongnu.org; Mon, 17 Dec 2012 15:45:20 -0500
Date: Mon, 17 Dec 2012 22:48:11 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20121217204811.GB30842@redhat.com>
References: <20121217154521.GA28674@redhat.com> <50CF5CA2.7060800@suse.de>
	<50CF629A.4090005@redhat.com> <50CF6384.9040809@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <50CF6384.9040809@suse.de>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] virtio: make bindings typesafe
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, fred.konrad@greensocs.com

On Mon, Dec 17, 2012 at 07:25:08PM +0100, Andreas F=E4rber wrote:
> Am 17.12.2012 19:21, schrieb Paolo Bonzini:
> > Il 17/12/2012 18:55, Andreas F=E4rber ha scritto:
> >> Am 17.12.2012 16:45, schrieb Michael S. Tsirkin:
> >>> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> >>> index 3ea4140..63ae888 100644
> >>> --- a/hw/virtio-pci.c
> >>> +++ b/hw/virtio-pci.c
> >>> @@ -98,34 +98,34 @@ bool virtio_is_big_endian(void);
> >>> =20
> >>>  /* virtio device */
> >>> =20
> >>> -static void virtio_pci_notify(void *opaque, uint16_t vector)
> >>> +static void virtio_pci_notify(DeviceState *d, uint16_t vector)
> >>>  {
> >>> -    VirtIOPCIProxy *proxy =3D opaque;
> >>> +    VirtIOPCIProxy *proxy =3D container_of(d, VirtIOPCIProxy, pci_=
dev.qdev);
> >>
> >> Nack. This is going the wrong direction QOM-wise and you among all
> >> others know that from PCI host bridges!
> >=20
> > Well, that's just a difference of VIRTIO_PCI_PROXY(d) vs. container_o=
f.
>=20
> VIRTIO_PCI_PROXY(d) would be acceptable, sure. But as-is this patch jus=
t
> pushes unnecessary work on Fred, me, you or anyone else who works with =
QOM.
>=20
> Andreas

What's VIRTIO_PCI_PROXY? Note this is data path we do not want extra
code.


> --=20
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn=
berg