From: Stefan Hajnoczi <stefanha@redhat.com>
To: Amos Kong <akong@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] net: clean up network at qemu process termination
Date: Tue, 18 Dec 2012 14:53:58 +0100 [thread overview]
Message-ID: <20121218135358.GD6697@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1355235615-30831-1-git-send-email-akong@redhat.com>
On Tue, Dec 11, 2012 at 10:20:15PM +0800, Amos Kong wrote:
> We don't clean up network if fails to parse "-device" parameters without
> calling net_cleanup(). I touch a problem, the tap device which is
> created by qemu-ifup script could not be removed by qemu-ifdown script.
> Some similar problems also exist in vl.c
>
> In this patch, if network initialization successes, a cleanup function
> will be registered to be called at qemu process termination.
>
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
> v2: register cleanup function before network initialization
> ---
> vl.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
Thanks, applied to the net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
prev parent reply other threads:[~2012-12-18 13:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 13:45 [Qemu-devel] [PATCH] net: clean up network at qemu process termination Amos Kong
2012-12-11 14:03 ` Michael S. Tsirkin
2012-12-11 14:20 ` [Qemu-devel] [PATCH v2] " Amos Kong
2012-12-11 15:07 ` Michael S. Tsirkin
2012-12-18 13:53 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121218135358.GD6697@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=akong@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).