From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkxcR-00007y-JX for qemu-devel@nongnu.org; Tue, 18 Dec 2012 08:54:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TkxcO-0003EN-OT for qemu-devel@nongnu.org; Tue, 18 Dec 2012 08:54:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkxcO-0003EH-HM for qemu-devel@nongnu.org; Tue, 18 Dec 2012 08:54:00 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBIDrx4c020655 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 18 Dec 2012 08:53:59 -0500 Date: Tue, 18 Dec 2012 14:53:58 +0100 From: Stefan Hajnoczi Message-ID: <20121218135358.GD6697@stefanha-thinkpad.redhat.com> References: <1355233554-28130-1-git-send-email-akong@redhat.com> <1355235615-30831-1-git-send-email-akong@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1355235615-30831-1-git-send-email-akong@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] net: clean up network at qemu process termination List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: qemu-devel@nongnu.org, mst@redhat.com On Tue, Dec 11, 2012 at 10:20:15PM +0800, Amos Kong wrote: > We don't clean up network if fails to parse "-device" parameters without > calling net_cleanup(). I touch a problem, the tap device which is > created by qemu-ifup script could not be removed by qemu-ifdown script. > Some similar problems also exist in vl.c > > In this patch, if network initialization successes, a cleanup function > will be registered to be called at qemu process termination. > > Signed-off-by: Amos Kong > --- > v2: register cleanup function before network initialization > --- > vl.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) Thanks, applied to the net tree: https://github.com/stefanha/qemu/commits/net Stefan