From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkyFd-0005kq-HM for qemu-devel@nongnu.org; Tue, 18 Dec 2012 09:34:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TkyFX-0006ae-FS for qemu-devel@nongnu.org; Tue, 18 Dec 2012 09:34:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28070) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkyFX-0006aa-7y for qemu-devel@nongnu.org; Tue, 18 Dec 2012 09:34:27 -0500 Date: Tue, 18 Dec 2012 15:34:23 +0100 From: Stefan Hajnoczi Message-ID: <20121218143423.GB10813@stefanha-thinkpad.redhat.com> References: <1355580573-19323-1-git-send-email-sw@weilnetz.de> <1355580573-19323-2-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1355580573-19323-2-git-send-email-sw@weilnetz.de> Subject: Re: [Qemu-devel] [PATCH 1/4] block: Add special error code for wrong format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Kevin Wolf , qemu-devel@nongnu.org On Sat, Dec 15, 2012 at 03:09:30PM +0100, Stefan Weil wrote: > The block drivers normally return -errno for typical errors. > There is no appropriate error code for "wrong format", so > use a special error code which does not conflict with system > error codes. ENOTTY is used when something is of the wrong type. Since the name "ENOTTY" is not clear, defining a new error code makes sense though. Stefan