From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48713)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Tkybn-00033Y-C9
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 09:57:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Tkybh-0004j3-T7
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 09:57:27 -0500
Received: from mail-wi0-f179.google.com ([209.85.212.179]:48758)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Tkybh-0004ix-Lx
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 09:57:21 -0500
Received: by mail-wi0-f179.google.com with SMTP id o1so455085wic.0
	for <qemu-devel@nongnu.org>; Tue, 18 Dec 2012 06:57:20 -0800 (PST)
Date: Tue, 18 Dec 2012 15:57:17 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20121218145717.GA11063@stefanha-thinkpad.redhat.com>
References: <1355144985-12897-1-git-send-email-stefanha@redhat.com>
	<1355144985-12897-13-git-send-email-stefanha@redhat.com>
	<20121216160853.GC15790@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20121216160853.GC15790@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 12/12] virtio-blk: add
 x-data-plane=on|off performance feature
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, khoa@us.ibm.com, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Asias He <asias@redhat.com>

On Sun, Dec 16, 2012 at 06:08:53PM +0200, Michael S. Tsirkin wrote:
> On Mon, Dec 10, 2012 at 02:09:45PM +0100, Stefan Hajnoczi wrote:
> > @@ -33,6 +34,7 @@ typedef struct VirtIOBlock
> >      VirtIOBlkConf *blk;
> >      unsigned short sector_mask;
> >      DeviceState *qdev;
> > +    VirtIOBlockDataPlane *dataplane;
> >  } VirtIOBlock;
> >  
> >  static VirtIOBlock *to_virtio_blk(VirtIODevice *vdev)
> > @@ -407,6 +409,14 @@ static void virtio_blk_handle_output(VirtIODevice *vdev, VirtQueue *vq)
> >          .num_writes = 0,
> >      };
> >  
> > +    /* Some guests kick before setting VIRTIO_CONFIG_S_DRIVER_OK so start
> > +     * dataplane here instead of waiting for .set_status().
> > +     */
> 
> By the way which guests are these?

I ran a Windows 8 guest today with build 48 virtio-win drivers.  It
notifies before the device gets its .set_status() callback invoked.

But I could swear I've seen Linux guests do this too.

> > +    if (s->dataplane) {
> > +        virtio_blk_data_plane_start(s->dataplane);
> > +        return;
> > +    }
> > +
> 
> By the way it's chunk such as this that I meant: it's not
> compiled out even if dataplane is disabled by configure.
> Naither is the extra field in the struct.

Okay.

Stefan