From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, e.voevodin@samsung.com,
mark.burton@greensocs.com, qemu-devel@nongnu.org,
stefanha@redhat.com, cornelia.huck@de.ibm.com,
Paolo Bonzini <pbonzini@redhat.com>,
afaerber@suse.de, fred.konrad@greensocs.com
Subject: Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring.
Date: Tue, 18 Dec 2012 17:14:02 +0200 [thread overview]
Message-ID: <20121218151402.GD27400@redhat.com> (raw)
In-Reply-To: <CAFEAcA9Uj04CaP6mtmQyaXSxaGo7Rg7giYvoLETX-QB=8=bm1Q@mail.gmail.com>
On Tue, Dec 18, 2012 at 02:56:58PM +0000, Peter Maydell wrote:
> > True, it is not pure qdev, but it is much simpler and doesn't require
> > convincing grumpy maintainers. :)
>
> I'm not actually personally all that attached to this design -- it's just
> trying to implement a suggestion by Anthony.
>
> It does seem frankly bizarre that adding a new transport requires
> knowing about all the backends (notice how s390-virtio-bus.c has
> to register types for each backend).
I agree it's not pretty. The issue is that things like e.g.
PCI class need per-device handling. We could invent our
own class system but that seems like overkill:
it's rare enough to add new devices.
> The kernel gets the transport
> vs backend separation much cleaner and it was much easier to
> add the virtio support there.
>
> -- PMM
By the way even there the separation does confuse users sometimes.
Things like autoloading are broken
and some tools poking at sysfs get confused.
At this point it's probably not worth changing though.
--
MST
next prev parent reply other threads:[~2012-12-18 15:11 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 13:32 [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring fred.konrad
2012-12-07 13:32 ` [Qemu-devel] [RFC PATCH v6 1/6] qdev : add a maximum device allowed field for the bus fred.konrad
2012-12-07 13:32 ` [Qemu-devel] [RFC PATCH v6 2/6] virtio-bus : Introduce virtio-bus fred.konrad
2012-12-07 13:32 ` [Qemu-devel] [RFC PATCH v6 3/6] virtio-pci-bus : Introduce virtio-pci-bus fred.konrad
2012-12-07 13:32 ` [Qemu-devel] [RFC PATCH v6 4/6] virtio-pci : Refactor virtio-pci device fred.konrad
2012-12-07 13:32 ` [Qemu-devel] [RFC PATCH v6 5/6] virtio-device : Refactor virtio-device fred.konrad
2012-12-07 13:32 ` [Qemu-devel] [RFC PATCH v6 6/6] virtio-blk : Add the virtio-blk device fred.konrad
2012-12-07 14:53 ` Peter Maydell
2012-12-17 15:45 ` [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring Michael S. Tsirkin
2012-12-17 17:13 ` KONRAD Frédéric
2012-12-17 20:46 ` Michael S. Tsirkin
2012-12-18 10:33 ` Peter Maydell
2012-12-18 11:01 ` Michael S. Tsirkin
2012-12-18 11:26 ` Peter Maydell
2012-12-18 11:50 ` Paolo Bonzini
2012-12-18 12:06 ` Peter Maydell
2012-12-18 13:10 ` Michael S. Tsirkin
2012-12-18 14:00 ` Peter Maydell
2012-12-18 14:36 ` Paolo Bonzini
2012-12-18 14:56 ` Peter Maydell
2012-12-18 14:59 ` Paolo Bonzini
2012-12-18 15:42 ` Michael S. Tsirkin
2012-12-18 15:14 ` Michael S. Tsirkin [this message]
2012-12-18 14:51 ` Michael S. Tsirkin
2012-12-18 11:30 ` KONRAD Frédéric
2012-12-18 13:21 ` Michael S. Tsirkin
2013-01-07 20:12 ` Anthony Liguori
2013-01-07 20:59 ` Michael S. Tsirkin
2013-01-07 21:24 ` Anthony Liguori
2013-01-07 21:37 ` Michael S. Tsirkin
2013-01-07 21:51 ` Anthony Liguori
2013-01-07 22:15 ` Michael S. Tsirkin
2013-01-07 22:50 ` Anthony Liguori
2013-01-08 6:46 ` Michael S. Tsirkin
2013-01-07 22:16 ` Michael S. Tsirkin
2013-01-07 19:58 ` Michael S. Tsirkin
2013-01-07 20:02 ` Peter Maydell
2013-01-07 20:49 ` Michael S. Tsirkin
2013-01-07 21:32 ` Anthony Liguori
2013-01-07 20:14 ` Anthony Liguori
2013-01-08 9:56 ` KONRAD Frédéric
2013-01-08 14:02 ` Michael S. Tsirkin
2013-01-08 14:27 ` KONRAD Frédéric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121218151402.GD27400@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=e.voevodin@samsung.com \
--cc=fred.konrad@greensocs.com \
--cc=mark.burton@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).