From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tkyp6-0002ol-OW for qemu-devel@nongnu.org; Tue, 18 Dec 2012 10:11:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tkyoz-00006P-NI for qemu-devel@nongnu.org; Tue, 18 Dec 2012 10:11:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tkyoz-00006B-GB for qemu-devel@nongnu.org; Tue, 18 Dec 2012 10:11:05 -0500 Date: Tue, 18 Dec 2012 17:14:02 +0200 From: "Michael S. Tsirkin" Message-ID: <20121218151402.GD27400@redhat.com> References: <20121217154508.GA28712@redhat.com> <20121218110153.GC22586@redhat.com> <50D05898.9030506@redhat.com> <20121218131043.GA26110@redhat.com> <50D07F50.6010800@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: aliguori@us.ibm.com, e.voevodin@samsung.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, stefanha@redhat.com, cornelia.huck@de.ibm.com, Paolo Bonzini , afaerber@suse.de, fred.konrad@greensocs.com On Tue, Dec 18, 2012 at 02:56:58PM +0000, Peter Maydell wrote: > > True, it is not pure qdev, but it is much simpler and doesn't require > > convincing grumpy maintainers. :) > > I'm not actually personally all that attached to this design -- it's just > trying to implement a suggestion by Anthony. > > It does seem frankly bizarre that adding a new transport requires > knowing about all the backends (notice how s390-virtio-bus.c has > to register types for each backend). I agree it's not pretty. The issue is that things like e.g. PCI class need per-device handling. We could invent our own class system but that seems like overkill: it's rare enough to add new devices. > The kernel gets the transport > vs backend separation much cleaner and it was much easier to > add the virtio support there. > > -- PMM By the way even there the separation does confuse users sometimes. Things like autoloading are broken and some tools poking at sysfs get confused. At this point it's probably not worth changing though. -- MST