From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
Fabien Chouteau <chouteau@adacore.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block/raw-win32: Fix compiler warnings (wrong format specifiers)
Date: Tue, 18 Dec 2012 16:23:35 +0100 [thread overview]
Message-ID: <20121218152335.GD11063@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1355773201-11576-1-git-send-email-sw@weilnetz.de>
On Mon, Dec 17, 2012 at 08:40:01PM +0100, Stefan Weil wrote:
> Commit fbcad04d6bfdff937536eb23088a01a280a1a3af added fprintf statements
> with wrong format specifiers.
>
> GetLastError() returns a DWORD which is unsigned long, so %lu must be used.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> Do we want those fprintf statements here at all?
>
> - Stefan
>
> block/raw-win32.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to the block patches tree:
https://github.com/stefanha/qemu/commits/block
Stefan
prev parent reply other threads:[~2012-12-18 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 19:40 [Qemu-devel] [PATCH] block/raw-win32: Fix compiler warnings (wrong format specifiers) Stefan Weil
2012-12-17 19:44 ` Andreas Färber
2012-12-18 13:26 ` Fabien Chouteau
2012-12-18 15:23 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121218152335.GD11063@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=chouteau@adacore.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).