From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tkz1F-0007vY-6A for qemu-devel@nongnu.org; Tue, 18 Dec 2012 10:23:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tkz1B-0004Qw-Em for qemu-devel@nongnu.org; Tue, 18 Dec 2012 10:23:45 -0500 Received: from mail-wi0-f173.google.com ([209.85.212.173]:61671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tkz1B-0004Ql-3K for qemu-devel@nongnu.org; Tue, 18 Dec 2012 10:23:41 -0500 Received: by mail-wi0-f173.google.com with SMTP id hn17so2786162wib.12 for ; Tue, 18 Dec 2012 07:23:40 -0800 (PST) Date: Tue, 18 Dec 2012 16:23:35 +0100 From: Stefan Hajnoczi Message-ID: <20121218152335.GD11063@stefanha-thinkpad.redhat.com> References: <1355773201-11576-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1355773201-11576-1-git-send-email-sw@weilnetz.de> Subject: Re: [Qemu-devel] [PATCH] block/raw-win32: Fix compiler warnings (wrong format specifiers) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Kevin Wolf , Fabien Chouteau , qemu-devel@nongnu.org, Stefan Hajnoczi On Mon, Dec 17, 2012 at 08:40:01PM +0100, Stefan Weil wrote: > Commit fbcad04d6bfdff937536eb23088a01a280a1a3af added fprintf statements > with wrong format specifiers. > > GetLastError() returns a DWORD which is unsigned long, so %lu must be used. > > Signed-off-by: Stefan Weil > --- > > Do we want those fprintf statements here at all? > > - Stefan > > block/raw-win32.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks, applied to the block patches tree: https://github.com/stefanha/qemu/commits/block Stefan