From: Stefan Hajnoczi <stefanha@gmail.com>
To: John Spencer <maillist-qemu@barfooze.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/4] fix build error on ARM due to wrong glibc check
Date: Tue, 18 Dec 2012 17:23:41 +0100 [thread overview]
Message-ID: <20121218162341.GD12099@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1355122786-29243-2-git-send-email-maillist-qemu@barfooze.de>
On Mon, Dec 10, 2012 at 07:59:44AM +0100, John Spencer wrote:
> the test for glibc < 2 "succeeds" wrongly for any non-glibc C library,
> and breaks the build on musl libc.
> we must first test if __GLIBC__ is defined at all, before using it
> unconditionally.
>
> Signed-off-by: John Spencer <maillist-qemu@barfooze.de>
>
> ---
> user-exec.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied Patch 2 to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
next prev parent reply other threads:[~2012-12-18 16:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 6:59 [Qemu-devel] [PATCH 1/4] fix implicit declaration of syscall() in linux-user/mmap.c John Spencer
2012-12-10 6:59 ` [Qemu-devel] [PATCH 2/4] fix build error on ARM due to wrong glibc check John Spencer
2012-12-10 17:46 ` Stefan Weil
2012-12-18 16:23 ` Stefan Hajnoczi [this message]
2012-12-10 6:59 ` [Qemu-devel] [PATCH 3/4] fix implicit declaration of syscall() in linux-user/syscall.c John Spencer
2012-12-10 17:49 ` Stefan Weil
2012-12-11 1:23 ` John Spencer
2012-12-11 6:07 ` Stefan Weil
2012-12-10 6:59 ` [Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups() John Spencer
2012-12-10 17:47 ` Stefan Weil
2012-12-18 16:23 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-12-10 17:44 ` [Qemu-devel] [PATCH 1/4] fix implicit declaration of syscall() in linux-user/mmap.c Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121218162341.GD12099@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=maillist-qemu@barfooze.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).