From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TkzxQ-0002n5-Pm for qemu-devel@nongnu.org; Tue, 18 Dec 2012 11:23:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TkzxP-0004sA-OA for qemu-devel@nongnu.org; Tue, 18 Dec 2012 11:23:52 -0500 Date: Tue, 18 Dec 2012 17:23:41 +0100 From: Stefan Hajnoczi Message-ID: <20121218162341.GD12099@stefanha-thinkpad.redhat.com> References: <1355122786-29243-1-git-send-email-maillist-qemu@barfooze.de> <1355122786-29243-2-git-send-email-maillist-qemu@barfooze.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1355122786-29243-2-git-send-email-maillist-qemu@barfooze.de> Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/4] fix build error on ARM due to wrong glibc check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Spencer Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On Mon, Dec 10, 2012 at 07:59:44AM +0100, John Spencer wrote: > the test for glibc < 2 "succeeds" wrongly for any non-glibc C library, > and breaks the build on musl libc. > we must first test if __GLIBC__ is defined at all, before using it > unconditionally. > > Signed-off-by: John Spencer > > --- > user-exec.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied Patch 2 to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan