From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tkzxf-0003N2-1E for qemu-devel@nongnu.org; Tue, 18 Dec 2012 11:24:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tkzxc-0004uJ-U1 for qemu-devel@nongnu.org; Tue, 18 Dec 2012 11:24:06 -0500 Date: Tue, 18 Dec 2012 17:23:55 +0100 From: Stefan Hajnoczi Message-ID: <20121218162355.GE12099@stefanha-thinkpad.redhat.com> References: <1355122786-29243-1-git-send-email-maillist-qemu@barfooze.de> <1355122786-29243-4-git-send-email-maillist-qemu@barfooze.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1355122786-29243-4-git-send-email-maillist-qemu@barfooze.de> Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Spencer Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On Mon, Dec 10, 2012 at 07:59:46AM +0100, John Spencer wrote: > this declaration is wrong: > the correct prototype on linux is: > int setgroups(size_t size, const gid_t *list); > > since by default musl libc exposes this symbol in unistd.h > additionally to grp.h, the wrong declaration causes a build error. > > the proper fix is to simply include the correct header. > > Signed-off-by: John Spencer > > --- > linux-user/syscall.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied Patch 4 to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan