From: Stefan Hajnoczi <stefanha@gmail.com>
To: "陳韋任 (Wei-Ren Chen)" <chenwj@iis.sinica.edu.tw>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Evgeny Voevodin <e.voevodin@samsung.com>
Subject: Re: [Qemu-devel] [PATCH v2] exec.c: Use tb1->phys_hash_next directly in tb_remove
Date: Tue, 18 Dec 2012 17:37:53 +0100 [thread overview]
Message-ID: <20121218163753.GA29319@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <20121120235248.GA24638@cs.nctu.edu.tw>
On Wed, Nov 21, 2012 at 07:52:48AM +0800, 陳韋任 (Wei-Ren Chen) wrote:
> When tb_remove was first commited at fd6ce8f6, there were three different
> calls pass different names to offsetof. In current codebase, the other two
> calls are replaced with tb_page_remove. There is no need to have a general
> tb_remove. Omit passing the third parameter and using tb1->phys_hash_next
> directly.
>
> Signed-off-by: Chen Wei-Ren <chenwj@iis.sinica.edu.tw>
> ---
>
> v2: Address Peter's comment.
> - place comment used belong tb_remove above tb_phys_invalidate.
> - remove unnecessary bracket.
>
> exec.c | 12 +++++-------
> 1 files changed, 5 insertions(+), 7 deletions(-)
Please rebase onto qemu.git/master.
Stefan
next prev parent reply other threads:[~2012-12-18 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 23:52 [Qemu-devel] [PATCH v2] exec.c: Use tb1->phys_hash_next directly in tb_remove 陳韋任 (Wei-Ren Chen)
2012-11-21 8:03 ` Peter Maydell
2012-12-10 13:54 ` 陳韋任 (Wei-Ren Chen)
2012-12-18 16:37 ` Stefan Hajnoczi [this message]
2012-12-20 1:39 ` 陳韋任 (Wei-Ren Chen)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121218163753.GA29319@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=chenwj@iis.sinica.edu.tw \
--cc=e.voevodin@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).