From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tl0B4-0002rM-Eq for qemu-devel@nongnu.org; Tue, 18 Dec 2012 11:38:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tl0B3-0000p4-Bu for qemu-devel@nongnu.org; Tue, 18 Dec 2012 11:37:58 -0500 Received: from mail-wi0-f178.google.com ([209.85.212.178]:32805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tl0B3-0000ov-5p for qemu-devel@nongnu.org; Tue, 18 Dec 2012 11:37:57 -0500 Received: by mail-wi0-f178.google.com with SMTP id hn3so538957wib.11 for ; Tue, 18 Dec 2012 08:37:56 -0800 (PST) Date: Tue, 18 Dec 2012 17:37:53 +0100 From: Stefan Hajnoczi Message-ID: <20121218163753.GA29319@stefanha-thinkpad.redhat.com> References: <20121120235248.GA24638@cs.nctu.edu.tw> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20121120235248.GA24638@cs.nctu.edu.tw> Subject: Re: [Qemu-devel] [PATCH v2] exec.c: Use tb1->phys_hash_next directly in tb_remove List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?B?6Zmz6Z+L5Lu7IChXZWktUmVuIENoZW4p?= Cc: Peter Maydell , qemu-devel@nongnu.org, Evgeny Voevodin On Wed, Nov 21, 2012 at 07:52:48AM +0800, 陳韋任 (Wei-Ren Chen) wrote: > When tb_remove was first commited at fd6ce8f6, there were three different > calls pass different names to offsetof. In current codebase, the other two > calls are replaced with tb_page_remove. There is no need to have a general > tb_remove. Omit passing the third parameter and using tb1->phys_hash_next > directly. > > Signed-off-by: Chen Wei-Ren > --- > > v2: Address Peter's comment. > - place comment used belong tb_remove above tb_phys_invalidate. > - remove unnecessary bracket. > > exec.c | 12 +++++------- > 1 files changed, 5 insertions(+), 7 deletions(-) Please rebase onto qemu.git/master. Stefan