From: Igor Mammedov <imammedo@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/3] target-i386/cpu.c: coding style fix
Date: Tue, 18 Dec 2012 17:44:12 +0100 [thread overview]
Message-ID: <20121218174412.2a8078b6@nial.usersys.redhat.com> (raw)
In-Reply-To: <1355848163-29846-2-git-send-email-ehabkost@redhat.com>
On Tue, 18 Dec 2012 14:29:21 -0200
Eduardo Habkost <ehabkost@redhat.com> wrote:
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> target-i386/cpu.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 2d4fc42..fe27def 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1789,10 +1789,11 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t
> index, uint32_t count, /* XXX: The physical address space is limited to 42
> bits in exec.c. */ *eax = 0x00003028; /* 48 bits virtual, 40 bits
^^ you forgot TAB here
> physical */ } else {
> - if (env->cpuid_features & CPUID_PSE36)
> + if (env->cpuid_features & CPUID_PSE36) {
> *eax = 0x00000024; /* 36 bits physical */
> - else
> + } else {
> *eax = 0x00000020; /* 32 bits physical */
> + }
> }
> *ebx = 0;
> *ecx = 0;
next prev parent reply other threads:[~2012-12-18 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 16:29 [Qemu-devel] [PATCH 0/3] replace cpuid_*features fields with a featue word array (v3) Eduardo Habkost
2012-12-18 16:29 ` [Qemu-devel] [PATCH 1/3] target-i386/cpu.c: coding style fix Eduardo Habkost
2012-12-18 16:44 ` Igor Mammedov [this message]
2012-12-18 17:03 ` Eduardo Habkost
2012-12-18 18:33 ` Andreas Färber
2012-12-18 18:41 ` Eduardo Habkost
2012-12-18 16:29 ` [Qemu-devel] [PATCH 2/3] target-i386/cpu.c: remove last TAB character from the source Eduardo Habkost
2012-12-18 16:29 ` [Qemu-devel] [PATCH 3/3] target-i386: replace cpuid_*features fields with a feature word array Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121218174412.2a8078b6@nial.usersys.redhat.com \
--to=imammedo@redhat.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).