From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46323)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Tl0HB-0005CT-8x
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 11:44:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Tl0HA-0002qf-5Q
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 11:44:17 -0500
Received: from mx1.redhat.com ([209.132.183.28]:26339)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Tl0H9-0002qS-Tk
	for qemu-devel@nongnu.org; Tue, 18 Dec 2012 11:44:16 -0500
Date: Tue, 18 Dec 2012 17:44:12 +0100
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20121218174412.2a8078b6@nial.usersys.redhat.com>
In-Reply-To: <1355848163-29846-2-git-send-email-ehabkost@redhat.com>
References: <1355848163-29846-1-git-send-email-ehabkost@redhat.com>
	<1355848163-29846-2-git-send-email-ehabkost@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] target-i386/cpu.c: coding style fix
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Andreas =?ISO-8859-1?B?RuRyYmVy?= <afaerber@suse.de>

On Tue, 18 Dec 2012 14:29:21 -0200
Eduardo Habkost <ehabkost@redhat.com> wrote:

> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-i386/cpu.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 2d4fc42..fe27def 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1789,10 +1789,11 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t
> index, uint32_t count, /* XXX: The physical address space is limited to 42
> bits in exec.c. */ *eax = 0x00003028;	/* 48 bits virtual, 40 bits
                                       ^^ you forgot TAB here 
> physical */ } else {
> -            if (env->cpuid_features & CPUID_PSE36)
> +            if (env->cpuid_features & CPUID_PSE36) {
>                  *eax = 0x00000024; /* 36 bits physical */
> -            else
> +            } else {
>                  *eax = 0x00000020; /* 32 bits physical */
> +            }
>          }
>          *ebx = 0;
>          *ecx = 0;