From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tldo4-0001Pv-G0 for qemu-devel@nongnu.org; Thu, 20 Dec 2012 05:56:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tldo0-0004bO-M0 for qemu-devel@nongnu.org; Thu, 20 Dec 2012 05:56:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:31574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tldo0-0004b4-EB for qemu-devel@nongnu.org; Thu, 20 Dec 2012 05:56:48 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBKAuld9008504 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 Dec 2012 05:56:47 -0500 Date: Thu, 20 Dec 2012 10:56:43 +0000 From: "Daniel P. Berrange" Message-ID: <20121220105643.GK25577@redhat.com> References: <1355932747-1755-1-git-send-email-kraxel@redhat.com> <50D2ED39.6010608@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <50D2ED39.6010608@redhat.com> Subject: Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Privoznik Cc: pbonzini@redhat.com, Gerd Hoffmann , qemu-devel@nongnu.org On Thu, Dec 20, 2012 at 11:49:29AM +0100, Michal Privoznik wrote: > On 19.12.2012 16:58, Gerd Hoffmann wrote: > > Hi, > > > > Chardev hotplug patch series reloaded. Not finished yet, commit > > messages not finalized yet, totally untested other than building on > > linux+windows. > > > > I doubt I manage to finish (and test!) it before xmas. Nevertheless I > > wanna get the bits out of the door for you to see what is coming and for > > early reviews. It goes largely the route suggested by Paolo. > > > > cheers, > > Gerd > > > > Gerd Hoffmann (9): > > chardev: add error reporting for qemu_chr_new_from_opts > > chardev: fix QemuOpts lifecycle > > chardev: reduce chardev ifdef mess a bit > > chardev: hotplug, qmp, null > > chardev: hotplug, hmp > > chardev: hotplug, qmp, file > > chardev: hotplug, qmp, tty > > chardev: hotplug, qmp, serial > > chardev: hotplug, qmp, parallel > > > > hmp-commands.hx | 32 ++++++ > > hmp.c | 23 +++++ > > hmp.h | 2 + > > qapi-schema.json | 47 +++++++++ > > qemu-char.c | 280 ++++++++++++++++++++++++++++++++++++++++++++--------- > > qemu-char.h | 4 +- > > qmp-commands.hx | 50 ++++++++++ > > vl.c | 9 +- > > 8 files changed, 395 insertions(+), 52 deletions(-) > > > > Okay, the QMP interface seems sane to me (from libvirt POV). However, > what about other chardev types like pipe and vc? And I guess pty can be > covered by tty, right? No, QEMU's pty & tty types are different - the latter is about accessing host serial devices >>From libvirt's POV, I think the most important chardev types are pty, unix and tcp. The other types are pretty rarely used AFAICT. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|