From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Anthony Liguori" <aliguori@us.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Baron" <jbaron@redhat.com>,
"Blue Swirl" <blauwirbel@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Guan Xuetao" <gxt@mprc.pku.edu.cn>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH] MAkefile: dont rebuild vhost for each target
Date: Thu, 20 Dec 2012 16:20:37 +0200 [thread overview]
Message-ID: <20121220142037.GA23513@redhat.com> (raw)
We rebuild vhost_net for each target, but there's
no real reason to, we only have 2 variants: with and
without vhost-net.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Makefile.target | 1 +
hw/Makefile.objs | 5 +++--
hw/vhost_net_stub.c | 1 +
3 files changed, 5 insertions(+), 2 deletions(-)
create mode 100644 hw/vhost_net_stub.c
diff --git a/Makefile.target b/Makefile.target
index 8bbad38..f6fddbd 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -103,6 +103,7 @@ endif #CONFIG_BSD_USER
#########################################################
# System emulator target
ifdef CONFIG_SOFTMMU
+CONFIG_NO_VHOST_NET = $(if $(subst n,,$(CONFIG_VHOST_NET)),n,y)
CONFIG_NO_PCI = $(if $(subst n,,$(CONFIG_PCI)),n,y)
CONFIG_NO_KVM = $(if $(subst n,,$(CONFIG_KVM)),n,y)
CONFIG_NO_XEN = $(if $(subst n,,$(CONFIG_XEN)),n,y)
diff --git a/hw/Makefile.objs b/hw/Makefile.objs
index 2778035..360a43c 100644
--- a/hw/Makefile.objs
+++ b/hw/Makefile.objs
@@ -3,6 +3,9 @@ common-obj-y += loader.o
common-obj-$(CONFIG_VIRTIO) += virtio-console.o
common-obj-$(CONFIG_VIRTIO) += virtio-rng.o
common-obj-$(CONFIG_VIRTIO_PCI) += virtio-pci.o
+common-obj-$(CONFIG_VHOST_NET) += vhost_net.o
+common-obj-$(CONFIG_VHOST_NET) += vhost.o
+common-obj-$(CONFIG_NO_VHOST_NET) += vhost_net_stub.o
common-obj-y += fw_cfg.o
common-obj-$(CONFIG_PCI) += pci_bridge_dev.o
common-obj-$(CONFIG_PCI) += ioh3420.o xio3130_upstream.o xio3130_downstream.o
@@ -192,8 +195,6 @@ common-obj-$(CONFIG_XEN_BACKEND) += xen_console.o xenfb.o xen_disk.o xen_nic.o
# need to fix this properly
obj-$(CONFIG_VIRTIO) += virtio.o virtio-blk.o virtio-balloon.o virtio-net.o
obj-$(CONFIG_VIRTIO) += virtio-serial-bus.o virtio-scsi.o
-obj-$(CONFIG_SOFTMMU) += vhost_net.o
-obj-$(CONFIG_VHOST_NET) += vhost.o
obj-$(CONFIG_REALLY_VIRTFS) += 9pfs/
obj-$(CONFIG_VGA) += vga.o
obj-$(CONFIG_SOFTMMU) += device-hotplug.o
diff --git a/hw/vhost_net_stub.c b/hw/vhost_net_stub.c
new file mode 100644
index 0000000..387b578
--- /dev/null
+++ b/hw/vhost_net_stub.c
@@ -0,0 +1 @@
+#include "vhost_net.c"
--
MST
next reply other threads:[~2012-12-20 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 14:20 Michael S. Tsirkin [this message]
2012-12-20 14:37 ` [Qemu-devel] [PATCH] MAkefile: dont rebuild vhost for each target Paolo Bonzini
2012-12-20 14:54 ` Michael S. Tsirkin
2013-01-04 17:33 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220142037.GA23513@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=jbaron@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).