From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Anthony Liguori" <aliguori@us.ibm.com>,
"Jason Baron" <jbaron@redhat.com>,
qemu-devel@nongnu.org, "Blue Swirl" <blauwirbel@gmail.com>,
"Guan Xuetao" <gxt@mprc.pku.edu.cn>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] MAkefile: dont rebuild vhost for each target
Date: Thu, 20 Dec 2012 16:54:40 +0200 [thread overview]
Message-ID: <20121220145440.GA29343@redhat.com> (raw)
In-Reply-To: <50D322C6.7060604@redhat.com>
On Thu, Dec 20, 2012 at 03:37:58PM +0100, Paolo Bonzini wrote:
> Il 20/12/2012 15:20, Michael S. Tsirkin ha scritto:
> > diff --git a/hw/vhost_net_stub.c b/hw/vhost_net_stub.c
> > new file mode 100644
> > index 0000000..387b578
> > --- /dev/null
> > +++ b/hw/vhost_net_stub.c
> > @@ -0,0 +1 @@
> > +#include "vhost_net.c"
>
> Nice. As a follow-up, can you perhaps split the vhost_net.c file in two
> following the model of other *-stub.c files?
>
> Paolo
Still thinking about this - keeping it all in a single file makes
it easier to change interfaces, OTOH making stub separate
means less platforms need to be rebuilt when only implementation
changes.
next prev parent reply other threads:[~2012-12-20 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 14:20 [Qemu-devel] [PATCH] MAkefile: dont rebuild vhost for each target Michael S. Tsirkin
2012-12-20 14:37 ` Paolo Bonzini
2012-12-20 14:54 ` Michael S. Tsirkin [this message]
2013-01-04 17:33 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220145440.GA29343@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=jbaron@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).