From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41732)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TlhTJ-0007AS-5I
	for qemu-devel@nongnu.org; Thu, 20 Dec 2012 09:51:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TlhTG-0003zJ-6R
	for qemu-devel@nongnu.org; Thu, 20 Dec 2012 09:51:41 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53313)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1TlhTF-0003z7-Tm
	for qemu-devel@nongnu.org; Thu, 20 Dec 2012 09:51:38 -0500
Date: Thu, 20 Dec 2012 16:54:40 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20121220145440.GA29343@redhat.com>
References: <20121220142037.GA23513@redhat.com> <50D322C6.7060604@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <50D322C6.7060604@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] MAkefile: dont rebuild vhost for each
	target
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Jason Baron <jbaron@redhat.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>

On Thu, Dec 20, 2012 at 03:37:58PM +0100, Paolo Bonzini wrote:
> Il 20/12/2012 15:20, Michael S. Tsirkin ha scritto:
> > diff --git a/hw/vhost_net_stub.c b/hw/vhost_net_stub.c
> > new file mode 100644
> > index 0000000..387b578
> > --- /dev/null
> > +++ b/hw/vhost_net_stub.c
> > @@ -0,0 +1 @@
> > +#include "vhost_net.c"
> 
> Nice.  As a follow-up, can you perhaps split the vhost_net.c file in two
> following the model of other *-stub.c files?
> 
> Paolo

Still thinking about this - keeping it all in a single file makes
it easier to change interfaces, OTOH making stub separate
means less platforms need to be rebuilt when only implementation
changes.