From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TljEc-0003V6-Ad for qemu-devel@nongnu.org; Thu, 20 Dec 2012 11:44:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TljEX-00007M-GH for qemu-devel@nongnu.org; Thu, 20 Dec 2012 11:44:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49884) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TljEX-00007C-7x for qemu-devel@nongnu.org; Thu, 20 Dec 2012 11:44:33 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBKGiW4c003411 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 Dec 2012 11:44:32 -0500 Date: Thu, 20 Dec 2012 16:44:26 +0000 From: "Daniel P. Berrange" Message-ID: <20121220164426.GA27510@redhat.com> References: <1355932747-1755-1-git-send-email-kraxel@redhat.com> <50D2ED39.6010608@redhat.com> <20121220105643.GK25577@redhat.com> <50D2F23D.9000908@redhat.com> <50D2FA5D.30602@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <50D2FA5D.30602@redhat.com> Subject: Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Paolo Bonzini , qemu-devel@nongnu.org, Michal Privoznik On Thu, Dec 20, 2012 at 12:45:33PM +0100, Gerd Hoffmann wrote: > >>>> I doubt I manage to finish (and test!) it before xmas. > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > >>> Okay, the QMP interface seems sane to me (from libvirt POV). However, > >>> what about other chardev types like pipe and vc? And I guess pty can be > >>> covered by tty, right? > > > > I think that is the missing part. > > Exactly. > > /me wades through the socket code (unix+tcp) right now, which needs some > refactoring to make it fly. > > >> From libvirt's POV, I think the most important chardev types are pty, > >> unix and tcp. The other types are pretty rarely used AFAICT. > > pty looks like another non-trivial challenge. How does libvirt gather > the pty device today? IIRC there is some stderr parsing? Or was it > info chardev? With QMP we probably want switch to a more sane model > here ... Yes, these days we use info chardev, or query-chardev as appropriate for the monitor mode. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|