From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TmsF5-0005Md-Qn for qemu-devel@nongnu.org; Sun, 23 Dec 2012 15:33:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TmsF4-0007nX-Mw for qemu-devel@nongnu.org; Sun, 23 Dec 2012 15:33:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38587) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TmsF4-0007nT-Fg for qemu-devel@nongnu.org; Sun, 23 Dec 2012 15:33:50 -0500 Date: Sun, 23 Dec 2012 22:33:39 +0200 From: Alon Levy Message-ID: <20121223203339.GC7485@garlic> References: <466983004.47092829.1355395217322.JavaMail.root@redhat.com> <50C9E697.6040802@redhat.com> <50C9E9A2.7090102@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50C9E9A2.7090102@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision < 4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Uri Lublin , =?iso-8859-1?Q?S=F8ren?= Sandmann , Yonit Halperin , qemu-devel@nongnu.org, Arnon Gilboa On Thu, Dec 13, 2012 at 03:43:46PM +0100, Gerd Hoffmann wrote: > Hi, > > >> That is indeed a better solution, but it does change functionality. I > >> think it is correct but I'd like to get some other opinions - Uri, > >> Arnon, Yonit, Soren - any problems with dropping these? > >> > > Orientation is used in the Windows Display driver. It is used to set > > dmDisplayOrientation in DEVMODEW structure > > (http://msdn.microsoft.com/en-us/library/windows/hardware/ff552837(v=vs.85).aspx). > > What is supposed to happen in case the guest picks a mode with > orientation != 0? > > > So, I'm not sure we can just drop it. Moreover, we need at least 2 of > > the orientations, one for AxB resolution and the other for BxA. > > How do I switch a windows guest into 600x800? AFAIR it is just another mode that appears in the mode list, i.e. when enumerating the modes via the windows API or via the GUI. > > cheers, > Gerd > >