From: Stuart Brady <sdb@zubnet.me.uk>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] tcg-hppa: Fix brcond2 and setcond2
Date: Mon, 24 Dec 2012 22:26:29 +0000 [thread overview]
Message-ID: <20121224222629.GA22529@zubnet.me.uk> (raw)
In-Reply-To: <1348023588-6764-2-git-send-email-rth@twiddle.net>
On Tue, Sep 18, 2012 at 07:59:47PM -0700, Richard Henderson wrote:
> diff --git a/tcg/hppa/tcg-target.c b/tcg/hppa/tcg-target.c
> index 8b81b70..a76569d 100644
> --- a/tcg/hppa/tcg-target.c
> +++ b/tcg/hppa/tcg-target.c
> @@ -820,19 +820,34 @@ static void tcg_out_comclr(TCGContext *s, int cond, TCGArg ret,
> tcg_out32(s, op);
> }
[...]
> case TCG_COND_NE:
> - tcg_out_comclr(s, tcg_invert_cond(cond), TCG_REG_R0, al, bl, blconst);
> - tcg_out_brcond(s, cond, ah, bh, bhconst, label_index);
> + tcg_out_brcond(s, TCG_COND_NE, al, bl, bhconst, label_index);
> + tcg_out_brcond(s, TCG_COND_NE, ah, bh, bhconst, label_index);
> break;
I'm not sure whether it's possible to have blconst != bhconst, but I see
that 'bhconst' is accidentally used together with 'al' and 'bl' here.
It may be some time before I get around to submitting a patch for this,
so just mentioning it briefly.
--
Cheers,
Stuart Brady
next prev parent reply other threads:[~2012-12-24 22:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 2:59 [Qemu-devel] [PULL 0/2] tcg-hppa fixes Richard Henderson
2012-09-19 2:59 ` [Qemu-devel] [PATCH 1/2] tcg-hppa: Fix brcond2 and setcond2 Richard Henderson
2012-12-24 22:26 ` Stuart Brady [this message]
2012-09-19 2:59 ` [Qemu-devel] [PATCH 2/2] tcg-hppa: Fix broken load/store helpers Richard Henderson
2012-09-21 14:18 ` [Qemu-devel] [PULL 0/2] tcg-hppa fixes Richard Henderson
2012-09-21 18:18 ` Aurelien Jarno
2012-09-21 18:20 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121224222629.GA22529@zubnet.me.uk \
--to=sdb@zubnet.me.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).