From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TnGTq-00066C-Dp for qemu-devel@nongnu.org; Mon, 24 Dec 2012 17:26:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TnGTm-0005Ii-CV for qemu-devel@nongnu.org; Mon, 24 Dec 2012 17:26:42 -0500 Received: from b.painless.aa.net.uk ([81.187.30.52]:51524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TnGTm-0005Ho-67 for qemu-devel@nongnu.org; Mon, 24 Dec 2012 17:26:38 -0500 Received: from zubnet.me.uk ([81.187.243.246] helo=circe) by b.painless.aa.net.uk with esmtp (Exim 4.72) (envelope-from ) id 1TnGTe-0006aR-F8 for qemu-devel@nongnu.org; Mon, 24 Dec 2012 22:26:30 +0000 Date: Mon, 24 Dec 2012 22:26:29 +0000 From: Stuart Brady Message-ID: <20121224222629.GA22529@zubnet.me.uk> References: <1348023588-6764-1-git-send-email-rth@twiddle.net> <1348023588-6764-2-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1348023588-6764-2-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH 1/2] tcg-hppa: Fix brcond2 and setcond2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Tue, Sep 18, 2012 at 07:59:47PM -0700, Richard Henderson wrote: > diff --git a/tcg/hppa/tcg-target.c b/tcg/hppa/tcg-target.c > index 8b81b70..a76569d 100644 > --- a/tcg/hppa/tcg-target.c > +++ b/tcg/hppa/tcg-target.c > @@ -820,19 +820,34 @@ static void tcg_out_comclr(TCGContext *s, int cond, TCGArg ret, > tcg_out32(s, op); > } [...] > case TCG_COND_NE: > - tcg_out_comclr(s, tcg_invert_cond(cond), TCG_REG_R0, al, bl, blconst); > - tcg_out_brcond(s, cond, ah, bh, bhconst, label_index); > + tcg_out_brcond(s, TCG_COND_NE, al, bl, bhconst, label_index); > + tcg_out_brcond(s, TCG_COND_NE, ah, bh, bhconst, label_index); > break; I'm not sure whether it's possible to have blconst != bhconst, but I see that 'bhconst' is accidentally used together with 'al' and 'bl' here. It may be some time before I get around to submitting a patch for this, so just mentioning it briefly. -- Cheers, Stuart Brady