From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40369)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1ToIy4-0003z5-2s
	for qemu-devel@nongnu.org; Thu, 27 Dec 2012 14:18:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1ToIy2-0001aX-Rc
	for qemu-devel@nongnu.org; Thu, 27 Dec 2012 14:18:11 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45175)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1ToIy2-0001aM-K3
	for qemu-devel@nongnu.org; Thu, 27 Dec 2012 14:18:10 -0500
Date: Thu, 27 Dec 2012 20:18:06 +0100
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20121227201806.5cb6aeee@thinkpad.mammed.net>
In-Reply-To: <20121227190916.GP18372@otherpad.lan.raisama.net>
References: <1356620376-23501-1-git-send-email-imammedo@redhat.com>
	<1356620376-23501-15-git-send-email-imammedo@redhat.com>
	<20121227190916.GP18372@otherpad.lan.raisama.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 14/20] target-i386: print depricated
 warning if xlevel < 0x80000000
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, afaerber@suse.de

On Thu, 27 Dec 2012 17:09:16 -0200
Eduardo Habkost <ehabkost@redhat.com> wrote:

> On Thu, Dec 27, 2012 at 03:59:30PM +0100, Igor Mammedov wrote:
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> >  target-i386/cpu.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> > index 084faeb..0764015 100644
> > --- a/target-i386/cpu.c
> > +++ b/target-i386/cpu.c
> > @@ -1334,6 +1334,8 @@ static int cpu_x86_parse_featurestr(x86_def_t *x86_cpu_def, char *features,
> >                      goto error;
> >                  }
> >                  if (numvalue < 0x80000000) {
> > +                    fprintf(stderr, "xlevel value shall always be >= 0x80000000"
> > +                            ", fixup will be depricated in future versions\n");
> 
> Did you mean: "deprecated"?  :-)
Yep, the same mistake in patch subj. I'll fix it.

Thanks!
> 
> >                      numvalue += 0x80000000;
> >                  }
> >                  x86_cpu_def->xlevel = numvalue;
> > -- 
> > 1.7.1
> > 
> 
> -- 
> Eduardo


-- 
Regards,
  Igor