From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Stefan Weil <sw@weilnetz.de>, John Snow <jsnow@redhat.com>,
Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH 1/3] nsis installer: List emulators in alphabetical order
Date: Sat, 5 Mar 2022 12:15:08 +0100 [thread overview]
Message-ID: <201294ed-9c3c-3920-ed34-361463aa46dd@gmail.com> (raw)
In-Reply-To: <20220305105743.2384766-2-peter.maydell@linaro.org>
On 5/3/22 11:57, Peter Maydell wrote:
> We currently list the emulators in the Windows installer's dialog
> in an essentially random order (it's whatever glob.glob() returns
> them to, which is filesystem-implementation-dependent). Add a
> call to sorted() so they appear in alphabetical order.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> scripts/nsis.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2022-03-05 11:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-05 10:57 [PATCH 0/3] windows installer: Fix warnings, mouse-over descriptions, item order Peter Maydell
2022-03-05 10:57 ` [PATCH 1/3] nsis installer: List emulators in alphabetical order Peter Maydell
2022-03-05 11:15 ` Philippe Mathieu-Daudé [this message]
2022-03-05 14:07 ` Stefan Weil
2022-03-07 19:25 ` John Snow
2022-03-07 20:16 ` Peter Maydell
2022-03-05 10:57 ` [PATCH 2/3] nsis installer: Suppress "ANSI targets are deprecated" warning Peter Maydell
2022-03-05 11:17 ` Philippe Mathieu-Daudé
2022-03-05 14:15 ` Stefan Weil
2022-03-05 10:57 ` [PATCH 3/3] nsis installer: Fix mouse-over descriptions for emulators Peter Maydell
2022-03-05 11:19 ` Philippe Mathieu-Daudé
2022-03-07 19:31 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201294ed-9c3c-3920-ed34-361463aa46dd@gmail.com \
--to=philippe.mathieu.daude@gmail.com \
--cc=crosa@redhat.com \
--cc=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).