From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39965)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TpzHD-0002Zk-2a
	for qemu-devel@nongnu.org; Tue, 01 Jan 2013 05:40:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TpzHC-0004Td-0z
	for qemu-devel@nongnu.org; Tue, 01 Jan 2013 05:40:55 -0500
Date: Tue, 1 Jan 2013 11:20:03 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20130101102003.GC16659@ohm.aurel32.net>
References: <1356179899-1268-1-git-send-email-sw@weilnetz.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1356179899-1268-1-git-send-email-sw@weilnetz.de>
Subject: Re: [Qemu-devel] [PATCH] target-mips: Remove semicolon from macro
	definition
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

On Sat, Dec 22, 2012 at 01:38:19PM +0100, Stefan Weil wrote:
> Macro RESTORE_FLUSH_MODE is similar to RESTORE_ROUNDING_MODE
> but included a semicolon.
> 
> The code which uses that macro also includes a semicolon,
> so the result was an empty statement.
> 
> Remove the superfluous semicolon from the macro definition.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> 
> Note:
> 
> After the patch, the modified line is shorter, but still longer than
> required by the coding conventions.
> 
>  target-mips/op_helper.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
> index e85edce..e3ab05c 100644
> --- a/target-mips/op_helper.c
> +++ b/target-mips/op_helper.c
> @@ -2175,7 +2175,7 @@ static unsigned int ieee_rm[] = {
>      set_float_rounding_mode(ieee_rm[env->active_fpu.fcr31 & 3], &env->active_fpu.fp_status)
>  
>  #define RESTORE_FLUSH_MODE \
> -    set_flush_to_zero((env->active_fpu.fcr31 & (1 << 24)) != 0, &env->active_fpu.fp_status);
> +    set_flush_to_zero((env->active_fpu.fcr31 & (1 << 24)) != 0, &env->active_fpu.fp_status)
>  
>  target_ulong helper_cfc1(CPUMIPSState *env, uint32_t reg)
>  {

Thanks, applied.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net