From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51659)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Tq0ce-0007hi-Vu
	for qemu-devel@nongnu.org; Tue, 01 Jan 2013 07:07:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Tq0cc-0000cV-4E
	for qemu-devel@nongnu.org; Tue, 01 Jan 2013 07:07:08 -0500
Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:52949)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Tq0cb-0000c2-Rw
	for qemu-devel@nongnu.org; Tue, 01 Jan 2013 07:07:05 -0500
Date: Tue, 1 Jan 2013 13:06:57 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20130101120657.GA4311@ohm.aurel32.net>
References: <1353794593-6147-1-git-send-email-sw@weilnetz.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1353794593-6147-1-git-send-email-sw@weilnetz.de>
Subject: Re: [Qemu-devel] [PATCH for 1.3] pflash_cfi01: Suppress warning
 when Linux probes for AMD flash
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On Sat, Nov 24, 2012 at 11:03:13PM +0100, Stefan Weil wrote:
> There are several ARM and MIPS boards which are manufactured with
> either Intel (pflash_cfi01.c) or AMD (pflash_cfi02.c) flash memory.
> 
> The Linux kernel supports both and first probes for AMD flash which
> resulted in one or two warnings from the Intel flash emulation:
> 
> pflash_write: Unimplemented flash cmd sequence (offset 0000000000000000, wcycle 0x0 cmd 0x0 value 0xf000f0)
> pflash_write: Unimplemented flash cmd sequence (offset 0000000000000000, wcycle 0x0 cmd 0x0 value 0xf0)
> 
> These warnings confuse users, so suppress them.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> 
> This is strictly speaking not a bug fix, but it fixes a warning
> which confuses QEMU users since a long time (see previous mails
> on qemu-devel and bug report).
> 
> It is also safe. Therefore I think it can be applied to 1.3.
> 
> Regards
> Stefan
> 
>  hw/pflash_cfi01.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c
> index 7d040b5..a4dbe19 100644
> --- a/hw/pflash_cfi01.c
> +++ b/hw/pflash_cfi01.c
> @@ -319,6 +319,9 @@ static void pflash_write(pflash_t *pfl, hwaddr offset,
>              DPRINTF("%s: Write to buffer\n", __func__);
>              pfl->status |= 0x80; /* Ready! */
>              break;
> +        case 0xf0: /* Probe for AMD flash */
> +            DPRINTF("%s: Probe for AMD flash\n", __func__);
> +            goto reset_flash;
>          case 0xff: /* Read array mode */
>              DPRINTF("%s: Read array mode\n", __func__);
>              goto reset_flash;

Thanks, applied.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net