From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqQgh-0006Sf-Pw for qemu-devel@nongnu.org; Wed, 02 Jan 2013 10:57:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TqQgf-0007ZB-Go for qemu-devel@nongnu.org; Wed, 02 Jan 2013 10:57:03 -0500 Received: from mail-we0-f170.google.com ([74.125.82.170]:62276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TqQgf-0007Yp-Bg for qemu-devel@nongnu.org; Wed, 02 Jan 2013 10:57:01 -0500 Received: by mail-we0-f170.google.com with SMTP id r1so6726455wey.15 for ; Wed, 02 Jan 2013 07:57:00 -0800 (PST) Date: Wed, 2 Jan 2013 16:56:58 +0100 From: Stefan Hajnoczi Message-ID: <20130102155658.GC12357@stefanha-thinkpad.redhat.com> References: <1355922436-8378-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1355922436-8378-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Anthony Liguori , Uri Lublin , qemu-devel@nongnu.org On Wed, Dec 19, 2012 at 02:07:16PM +0100, Stefan Hajnoczi wrote: > The spice_server pointer is a global variable and > vm_change_state_handler() therefore does not use its opaque parameter. > > The vm change state handler is added with a pointer to the spice_server > pointer. This is useless and we probably would not want 2 levels of > pointers. > > Signed-off-by: Stefan Hajnoczi > --- > ui/spice-core.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/ui/spice-core.c b/ui/spice-core.c > index ac46deb..c128c0b 100644 > --- a/ui/spice-core.c > +++ b/ui/spice-core.c > @@ -709,7 +709,7 @@ void qemu_spice_init(void) > qemu_spice_input_init(); > qemu_spice_audio_init(); > > - qemu_add_vm_change_state_handler(vm_change_state_handler, &spice_server); > + qemu_add_vm_change_state_handler(vm_change_state_handler, NULL); > > g_free(x509_key_file); > g_free(x509_cert_file); > @@ -736,8 +736,7 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin) > */ > spice_server = spice_server_new(); > spice_server_init(spice_server, &core_interface); > - qemu_add_vm_change_state_handler(vm_change_state_handler, > - &spice_server); > + qemu_add_vm_change_state_handler(vm_change_state_handler, NULL); > } > > return spice_server_add_interface(spice_server, sin); > -- > 1.8.0.2 Gerd, would you like to take this through the spice queue or should I put it in trivial-patches? Stefan