From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60553)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1TqRVk-0002R8-Rj
	for qemu-devel@nongnu.org; Wed, 02 Jan 2013 11:49:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1TqRVc-0006Lu-OV
	for qemu-devel@nongnu.org; Wed, 02 Jan 2013 11:49:48 -0500
Received: from nodalink.pck.nerim.net ([62.212.105.220]:56321
	helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1TqRVc-0006LP-Gj
	for qemu-devel@nongnu.org; Wed, 02 Jan 2013 11:49:40 -0500
Date: Wed, 2 Jan 2013 17:50:01 +0100
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20130102165000.GA29742@irqsave.net>
References: <1357143393-29832-1-git-send-email-benoit@irqsave.net>
	<1357143393-29832-31-git-send-email-benoit@irqsave.net>
	<50E4635E.60605@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <50E4635E.60605@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC V4 30/30] qemu-iotests: Filter dedup=on/off
 so existing tests don't break.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com


Ack.
There is more than one patch to move.
I'll do in for the next RFC.

Regards

Beno=EEt

Le Wednesday 02 Jan 2013 =E0 09:42:06 (-0700), Eric Blake a =E9crit :
> On 01/02/2013 09:16 AM, Beno=EEt Canet wrote:
> > Signed-off-by: Benoit Canet <benoit@irqsave.net>
> > ---
> >  tests/qemu-iotests/common.rc |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common=
.rc
> > index aef5f52..72e746d 100644
> > --- a/tests/qemu-iotests/common.rc
> > +++ b/tests/qemu-iotests/common.rc
> > @@ -124,7 +124,8 @@ _make_test_img()
> >              -e "s# compat=3D'[^']*'##g" \
> >              -e "s# compat6=3D\\(on\\|off\\)##g" \
> >              -e "s# static=3D\\(on\\|off\\)##g" \
> > -            -e "s# lazy_refcounts=3D\\(on\\|off\\)##g"
> > +            -e "s# lazy_refcounts=3D\\(on\\|off\\)##g" \
> > +            -e "s# dedup=3D\\('sha256'\\|'skein'\\|'sha3'\\)##g"
>=20
> Shouldn't this patch be hoisted earlier into the series, or even
> squashed in with the patch that introduced the temporary test failures?
>  That is, you want 'git bisect' to pass on every patch in the series,
> rather than introducing problems in one patch that only get cleaned up
> in a later patch.
>=20
> --=20
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>=20