qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org,
	David Gibson <david@gibson.dropbear.id.au>,
	qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] pseries: Remove unneeded include statement (fixes MinGW builds)
Date: Thu, 3 Jan 2013 09:59:46 +0100	[thread overview]
Message-ID: <20130103085946.GA11586@stefanha-thinkpad.muc.redhat.com> (raw)
In-Reply-To: <1355986241-32461-1-git-send-email-sw@weilnetz.de>

On Thu, Dec 20, 2012 at 07:50:41AM +0100, Stefan Weil wrote:
> sys/mman.h is not needed (tested on Linux) and unavailable for MinGW,
> so remove it.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  hw/spapr_nvram.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I audited the code and cannot see anything that would require
<sys/mman.h>.

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

  reply	other threads:[~2013-01-03  9:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-20  6:50 [Qemu-devel] [PATCH] pseries: Remove unneeded include statement (fixes MinGW builds) Stefan Weil
2013-01-03  8:59 ` Stefan Hajnoczi [this message]
2013-01-03  9:58   ` David Gibson
  -- strict thread matches above, loose matches on Subject: below --
2012-12-20  6:49 Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130103085946.GA11586@stefanha-thinkpad.muc.redhat.com \
    --to=stefanha@gmail.com \
    --cc=agraf@suse.de \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).