* [Qemu-devel] [PATCH] pseries: Remove unneeded include statement (fixes MinGW builds)
@ 2012-12-20 6:49 Stefan Weil
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Weil @ 2012-12-20 6:49 UTC (permalink / raw)
To: qemu-trivial
Cc: Alexander Graf, Stefan Weil, qemu-ppc, qemu-devel, David Gibson
sys/mman.h is not needed (tested on Linux) and unavailable for MinGW,
so remove it.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/spapr_nvram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/spapr_nvram.c b/hw/spapr_nvram.c
index f20f6b4..680cdba 100644
--- a/hw/spapr_nvram.c
+++ b/hw/spapr_nvram.c
@@ -21,7 +21,7 @@
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/
-#include <sys/mman.h>
+
#include <libfdt.h>
#include "sysemu/device_tree.h"
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH] pseries: Remove unneeded include statement (fixes MinGW builds)
@ 2012-12-20 6:50 Stefan Weil
2013-01-03 8:59 ` Stefan Hajnoczi
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Weil @ 2012-12-20 6:50 UTC (permalink / raw)
To: qemu-trivial
Cc: Alexander Graf, Stefan Weil, qemu-ppc, qemu-devel, David Gibson
sys/mman.h is not needed (tested on Linux) and unavailable for MinGW,
so remove it.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/spapr_nvram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/spapr_nvram.c b/hw/spapr_nvram.c
index f20f6b4..680cdba 100644
--- a/hw/spapr_nvram.c
+++ b/hw/spapr_nvram.c
@@ -21,7 +21,7 @@
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/
-#include <sys/mman.h>
+
#include <libfdt.h>
#include "sysemu/device_tree.h"
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] pseries: Remove unneeded include statement (fixes MinGW builds)
2012-12-20 6:50 [Qemu-devel] [PATCH] pseries: Remove unneeded include statement (fixes MinGW builds) Stefan Weil
@ 2013-01-03 8:59 ` Stefan Hajnoczi
2013-01-03 9:58 ` David Gibson
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Hajnoczi @ 2013-01-03 8:59 UTC (permalink / raw)
To: Stefan Weil
Cc: qemu-trivial, David Gibson, qemu-ppc, Alexander Graf, qemu-devel
On Thu, Dec 20, 2012 at 07:50:41AM +0100, Stefan Weil wrote:
> sys/mman.h is not needed (tested on Linux) and unavailable for MinGW,
> so remove it.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/spapr_nvram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I audited the code and cannot see anything that would require
<sys/mman.h>.
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] pseries: Remove unneeded include statement (fixes MinGW builds)
2013-01-03 8:59 ` Stefan Hajnoczi
@ 2013-01-03 9:58 ` David Gibson
0 siblings, 0 replies; 4+ messages in thread
From: David Gibson @ 2013-01-03 9:58 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: qemu-trivial, Stefan Weil, qemu-ppc, Alexander Graf, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
On Thu, Jan 03, 2013 at 09:59:46AM +0100, Stefan Hajnoczi wrote:
> On Thu, Dec 20, 2012 at 07:50:41AM +0100, Stefan Weil wrote:
> > sys/mman.h is not needed (tested on Linux) and unavailable for MinGW,
> > so remove it.
> >
> > Signed-off-by: Stefan Weil <sw@weilnetz.de>
> > ---
> > hw/spapr_nvram.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I audited the code and cannot see anything that would require
> <sys/mman.h>.
Oh, yes, that would have been from an early draft that directly
mmap()ed a backing file rather than using the block layer. It
shouldn't be needed any more.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-03 10:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-20 6:50 [Qemu-devel] [PATCH] pseries: Remove unneeded include statement (fixes MinGW builds) Stefan Weil
2013-01-03 8:59 ` Stefan Hajnoczi
2013-01-03 9:58 ` David Gibson
-- strict thread matches above, loose matches on Subject: below --
2012-12-20 6:49 Stefan Weil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).