From: David Gibson <david@gibson.dropbear.id.au>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>,
qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] pseries: Remove unneeded include statement (fixes MinGW builds)
Date: Thu, 3 Jan 2013 20:58:30 +1100 [thread overview]
Message-ID: <20130103095830.GG4729@truffula.fritz.box> (raw)
In-Reply-To: <20130103085946.GA11586@stefanha-thinkpad.muc.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
On Thu, Jan 03, 2013 at 09:59:46AM +0100, Stefan Hajnoczi wrote:
> On Thu, Dec 20, 2012 at 07:50:41AM +0100, Stefan Weil wrote:
> > sys/mman.h is not needed (tested on Linux) and unavailable for MinGW,
> > so remove it.
> >
> > Signed-off-by: Stefan Weil <sw@weilnetz.de>
> > ---
> > hw/spapr_nvram.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I audited the code and cannot see anything that would require
> <sys/mman.h>.
Oh, yes, that would have been from an early draft that directly
mmap()ed a backing file rather than using the block layer. It
shouldn't be needed any more.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-01-03 10:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 6:50 [Qemu-devel] [PATCH] pseries: Remove unneeded include statement (fixes MinGW builds) Stefan Weil
2013-01-03 8:59 ` Stefan Hajnoczi
2013-01-03 9:58 ` David Gibson [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-12-20 6:49 Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130103095830.GG4729@truffula.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).