From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tqhdg-00058W-Ju for qemu-devel@nongnu.org; Thu, 03 Jan 2013 05:03:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tqhdc-0007Pz-Je for qemu-devel@nongnu.org; Thu, 03 Jan 2013 05:03:04 -0500 Date: Thu, 3 Jan 2013 20:58:30 +1100 From: David Gibson Message-ID: <20130103095830.GG4729@truffula.fritz.box> References: <1355986241-32461-1-git-send-email-sw@weilnetz.de> <20130103085946.GA11586@stefanha-thinkpad.muc.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bpVaumkpfGNUagdU" Content-Disposition: inline In-Reply-To: <20130103085946.GA11586@stefanha-thinkpad.muc.redhat.com> Subject: Re: [Qemu-devel] [PATCH] pseries: Remove unneeded include statement (fixes MinGW builds) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-trivial@nongnu.org, Stefan Weil , qemu-ppc@nongnu.org, Alexander Graf , qemu-devel@nongnu.org --bpVaumkpfGNUagdU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 03, 2013 at 09:59:46AM +0100, Stefan Hajnoczi wrote: > On Thu, Dec 20, 2012 at 07:50:41AM +0100, Stefan Weil wrote: > > sys/mman.h is not needed (tested on Linux) and unavailable for MinGW, > > so remove it. > >=20 > > Signed-off-by: Stefan Weil > > --- > > hw/spapr_nvram.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > I audited the code and cannot see anything that would require > . Oh, yes, that would have been from an early draft that directly mmap()ed a backing file rather than using the block layer. It shouldn't be needed any more. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --bpVaumkpfGNUagdU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlDlVkYACgkQaILKxv3ab8aClACdETnTWisJSzbMjZch91zGSHNK uVoAn22nb1GvMfAON9QqZTSL9iXrf6qF =vssV -----END PGP SIGNATURE----- --bpVaumkpfGNUagdU--