From: "Benoît Canet" <benoit.canet@irqsave.net>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [RFC V4 00/30] QCOW2 deduplication
Date: Thu, 3 Jan 2013 18:18:40 +0100 [thread overview]
Message-ID: <20130103171840.GA4910@irqsave.net> (raw)
In-Reply-To: <1357143393-29832-1-git-send-email-benoit@irqsave.net>
Hello,
I started to write the deduplication metrics code in order to be able
to design asynchronous deduplication.
I am looking for a way to create a metric allowing deduplication to be paused
or resumed on a given threshold.
Does anyone have a sugestion regarding the metric that could be used for this ?
Best regards
Benoît
> Le Wednesday 02 Jan 2013 à 17:16:03 (+0100), Benoît Canet a écrit :
> This patchset is a cleanup of the previous QCOW2 deduplication rfc.
>
> One can compile and install https://github.com/wernerd/Skein3Fish and use the
> --enable-skein-dedup configure option in order to use the faster skein HASH.
>
> Images must be created with "-o dedup=[skein|sha256]" in order to activate the
> deduplication in the image.
>
> Deduplication is now fast enough to be usable.
>
> v4: Fix and complete qcow2 spec [Stefan]
> Hash the hash_algo field in the header extension [Stefan]
> Fix qcow2 spec [Eric]
> Remove pointer to hash and simplify hash memory management [Stefan]
> Rename and move qcow2_read_cluster_data to qcow2.c [Stefan]
> Document lock dropping behaviour of the previous function [Stefan]
> cleanup qcow2_dedup_read_missing_cluster_data [Stefan]
> rename *_offset to *_sect [Stefan]
> add a ./configure check for ssl [Stefan]
> Replace openssl by gnutls [Stefan]
> Implement Skein hashes
> Rewrite pretty every qcow2-dedup.c commits after Add
> qcow2_dedup_read_missing_and_concatenate to simplify the code
> Use 64KB deduplication hash block to reduce allocation flushes
> Use 64KB l2 tables to reduce allocation flushes [breaks compatibility]
> Use lazy refcounts to avoid qcow2_cache_set_dependency loops resultings
> in frequent caches flushes
> Do not create and load dedup RAM structures when bdrs->read_only is true
>
> v3: make it work barely
> replace kernel red black trees by gtree.
>
> *** BLURB HERE ***
>
> Benoît Canet (30):
> qcow2: Add deduplication to the qcow2 specification.
> qcow2: Add deduplication structures and fields.
> qcow2: Add qcow2_dedup_read_missing_and_concatenate
> qcow2: Make update_refcount public.
> qcow2: Create a way to link to l2 tables when deduplicating.
> qcow2: Add qcow2_dedup and related functions
> qcow2: Add qcow2_dedup_store_new_hashes.
> qcow2: Implement qcow2_compute_cluster_hash.
> qcow2: Extract qcow2_dedup_grow_table
> qcow2: Add qcow2_dedup_grow_table and use it.
> qcow2: create function to load deduplication hashes at startup.
> qcow2: Load and save deduplication table header extension.
> qcow2: Extract qcow2_do_table_init.
> qcow2-cache: Allow to choose table size at creation.
> qcow2: Add qcow2_dedup_init and qcow2_dedup_close.
> qcow2: Extract qcow2_add_feature and qcow2_remove_feature.
> block: Add qemu-img dedup create option.
> qcow2: Behave correctly when refcount reach 0 or 2^16.
> qcow2: Integrate deduplication in qcow2_co_writev loop.
> qcow2: Serialize write requests when deduplication is activated.
> qcow2: Add verification of dedup table.
> qcow2: Adapt checking of QCOW_OFLAG_COPIED for dedup.
> qcow2: Add check_dedup_l2 in order to check l2 of dedup table.
> qcow2: Do not overwrite existing entries with QCOW_OFLAG_COPIED.
> qcow2: Integrate SKEIN hash algorithm in deduplication.
> qcow2: Add lazy refcounts to deduplication to prevent
> qcow2_cache_set_dependency loops
> qcow2: Use large L2 table for deduplication.
> qcow: Set dedup cluster block size to 64KB.
> qcow2: init and cleanup deduplication.
> qemu-iotests: Filter dedup=on/off so existing tests don't break.
>
> block/Makefile.objs | 1 +
> block/qcow2-cache.c | 12 +-
> block/qcow2-cluster.c | 116 +++--
> block/qcow2-dedup.c | 1157 ++++++++++++++++++++++++++++++++++++++++++
> block/qcow2-refcount.c | 157 ++++--
> block/qcow2.c | 357 +++++++++++--
> block/qcow2.h | 120 ++++-
> configure | 55 ++
> docs/specs/qcow2.txt | 100 +++-
> include/block/block_int.h | 1 +
> tests/qemu-iotests/common.rc | 3 +-
> 11 files changed, 1955 insertions(+), 124 deletions(-)
> create mode 100644 block/qcow2-dedup.c
>
> --
> 1.7.10.4
>
prev parent reply other threads:[~2013-01-03 17:18 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 16:16 [Qemu-devel] [RFC V4 00/30] QCOW2 deduplication Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 01/30] qcow2: Add deduplication to the qcow2 specification Benoît Canet
2013-01-03 18:18 ` Eric Blake
2013-01-04 14:49 ` Benoît Canet
2013-01-16 14:50 ` Benoît Canet
2013-01-16 15:58 ` Eric Blake
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 02/30] qcow2: Add deduplication structures and fields Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 03/30] qcow2: Add qcow2_dedup_read_missing_and_concatenate Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 04/30] qcow2: Make update_refcount public Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 05/30] qcow2: Create a way to link to l2 tables when deduplicating Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 06/30] qcow2: Add qcow2_dedup and related functions Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 07/30] qcow2: Add qcow2_dedup_store_new_hashes Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 08/30] qcow2: Implement qcow2_compute_cluster_hash Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 09/30] qcow2: Extract qcow2_dedup_grow_table Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 10/30] qcow2: Add qcow2_dedup_grow_table and use it Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 11/30] qcow2: create function to load deduplication hashes at startup Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 12/30] qcow2: Load and save deduplication table header extension Benoît Canet
2013-01-05 0:02 ` Eric Blake
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 13/30] qcow2: Extract qcow2_do_table_init Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 14/30] qcow2-cache: Allow to choose table size at creation Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 15/30] qcow2: Add qcow2_dedup_init and qcow2_dedup_close Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 16/30] qcow2: Extract qcow2_add_feature and qcow2_remove_feature Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 17/30] block: Add qemu-img dedup create option Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 18/30] qcow2: Behave correctly when refcount reach 0 or 2^16 Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 19/30] qcow2: Integrate deduplication in qcow2_co_writev loop Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 20/30] qcow2: Serialize write requests when deduplication is activated Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 21/30] qcow2: Add verification of dedup table Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 22/30] qcow2: Adapt checking of QCOW_OFLAG_COPIED for dedup Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 23/30] qcow2: Add check_dedup_l2 in order to check l2 of dedup table Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 24/30] qcow2: Do not overwrite existing entries with QCOW_OFLAG_COPIED Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 25/30] qcow2: Integrate SKEIN hash algorithm in deduplication Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 26/30] qcow2: Add lazy refcounts to deduplication to prevent qcow2_cache_set_dependency loops Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 27/30] qcow2: Use large L2 table for deduplication Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 28/30] qcow: Set dedup cluster block size to 64KB Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 29/30] qcow2: init and cleanup deduplication Benoît Canet
2013-01-02 16:16 ` [Qemu-devel] [RFC V4 30/30] qemu-iotests: Filter dedup=on/off so existing tests don't break Benoît Canet
2013-01-02 16:42 ` Eric Blake
2013-01-02 16:50 ` Benoît Canet
2013-01-02 17:10 ` [Qemu-devel] [RFC V4 00/30] QCOW2 deduplication Troy Benjegerdes
2013-01-02 17:33 ` Benoît Canet
2013-01-02 18:01 ` Eric Blake
2013-01-02 18:16 ` Benoît Canet
2013-01-02 18:26 ` Troy Benjegerdes
2013-01-02 18:40 ` Benoît Canet
2013-01-02 18:47 ` ronnie sahlberg
2013-01-02 18:55 ` Benoît Canet
2013-01-02 19:18 ` Troy Benjegerdes
2013-01-03 2:16 ` ronnie sahlberg
2013-01-03 12:39 ` Stefan Hajnoczi
2013-01-03 19:51 ` Troy Benjegerdes
2013-01-04 7:09 ` Dietmar Maurer
2013-01-04 9:49 ` Stefan Hajnoczi
2013-01-03 17:18 ` Benoît Canet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130103171840.GA4910@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).