From: Stefan Hajnoczi <stefanha@gmail.com>
To: Onkar N Mahajan <onmahaja@linux.vnet.ibm.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Anthony Liguori <aligouri@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] Fix : Enable qemu-img QED image commit support.
Date: Fri, 4 Jan 2013 18:25:12 +0100 [thread overview]
Message-ID: <20130104172512.GA9339@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1357313548.13838.2.camel@oc2826874472.ibm.com>
On Fri, Jan 04, 2013 at 09:02:28PM +0530, Onkar N Mahajan wrote:
> @@ -695,7 +695,7 @@ static int coroutine_fn
> bdrv_qed_co_is_allocated(BlockDriverState *bs,
>
> static int bdrv_qed_make_empty(BlockDriverState *bs)
> {
> - return -ENOTSUP;
> + return 0;
> }
The only .bdrv_make_empty() caller is block.c:bdrv_commit():
if (drv->bdrv_make_empty) {
ret = drv->bdrv_make_empty(bs);
bdrv_flush(bs);
}
Perhaps it's best to drop bdrv_qed_make_empty() completely so
bdrv_commit() succeeds but we don't pretend to support
.bdrv_make_empty().
Stefan
next prev parent reply other threads:[~2013-01-04 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 15:32 [Qemu-devel] [PATCH] Fix : Enable qemu-img QED image commit support Onkar N Mahajan
2013-01-04 17:25 ` Stefan Hajnoczi [this message]
2013-01-04 20:21 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2013-01-04 10:02 Onkar N Mahajan
2013-01-04 20:21 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130104172512.GA9339@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=aligouri@us.ibm.com \
--cc=onmahaja@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).