From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38019)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <qzhou@redhat.com>) id 1TrPUT-0008Nr-ES
	for qemu-devel@nongnu.org; Sat, 05 Jan 2013 03:52:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <qzhou@redhat.com>) id 1TrPUS-00086W-I3
	for qemu-devel@nongnu.org; Sat, 05 Jan 2013 03:52:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:2522)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <qzhou@redhat.com>) id 1TrPUS-00086P-9z
	for qemu-devel@nongnu.org; Sat, 05 Jan 2013 03:52:28 -0500
Date: Sat, 5 Jan 2013 16:52:18 +0800
From: Qingtang Zhou <qzhou@redhat.com>
Message-ID: <20130105085218.GD3197@qzhou-work.nay.redhat.com>
References: <1356829329-30082-1-git-send-email-akong@redhat.com>
	<1356829329-30082-2-git-send-email-akong@redhat.com>
	<20121230011013.GA1742@t430s.redhat.com>
	<CAJnY6jrjTDBPBMgF=BcrYX=O2Yyb3y5Mopadr9H+Djf4wANoww@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJnY6jrjTDBPBMgF=BcrYX=O2Yyb3y5Mopadr9H+Djf4wANoww@mail.gmail.com>
Subject: Re: [Qemu-devel] [Virt-test-devel] [Autotest PATCH 2/2] virt run:
 add three logical case filters
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lucas Meneghel Rodrigues <lookkas@gmail.com>
Cc: Amos Kong <akong@redhat.com>, autotest-kernel@redhat.com, qemu-devel@nongnu.org, virt-test-devel@redhat.com

* On 2012-12-31 17:55:24 -0200, Lucas Meneghel Rodrigues (lookkas@gmail.com) wrote:
> Hmmm, about this one, I'm worried about making things more complex...
> 
> The way I see the problem at hand, I'd say if people want to customize
> things, they'd be better of creating their own, specialized config
> files rather than adding command line flags to manipulate the test
> sets.
Which kind of user interface do you want to provide to us (autotest user)?
A cli? But why does it can't specify more parameters or filters?
A config file? Why don't allow us to update tests.cfg?

I'm totally confused.

And why must I download that JeOS image?
I've setup my own image, why can't I use it directly?

Well, I prefer the old autotest style more now.

> 
> So my initial stand on this particular patch is NACK, but you might
> convince me otherwise :)
> 
> On Sat, Dec 29, 2012 at 11:10 PM, Amos Kong <akong@redhat.com> wrote:
> > On Sun, Dec 30, 2012 at 09:02:09AM +0800, Amos Kong wrote:
> >> This patch added there options for filtering cases by logics,
> >>
> >> For example:
> >> ./run -t qemu -c tests.cfg --oronly="WinXP Win7" --andonly="boot 64" --not="sp1"
> >
> > Oh! a typo in commitlog
> >
> >  ./run -t qemu -c tests.cfg --or="WinXP Win7" --and="boot 64" --not="sp1"
> >
> >>   (following cases will be executed)
> >>
> >> Test    1: virtio_blk.smp2.virtio_net.WinXP.64.boot
> >> Test    2: virtio_blk.smp2.virtio_net.Win7.64.boot
> > ...