From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Trr99-0004mK-CX for qemu-devel@nongnu.org; Sun, 06 Jan 2013 09:24:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Trr98-0001GG-9u for qemu-devel@nongnu.org; Sun, 06 Jan 2013 09:24:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:6980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Trr98-0001GA-2M for qemu-devel@nongnu.org; Sun, 06 Jan 2013 09:24:18 -0500 Date: Sun, 6 Jan 2013 16:24:13 +0200 From: Gleb Natapov Message-ID: <20130106142413.GK3440@redhat.com> References: <1357336872-7200-1-git-send-email-ehabkost@redhat.com> <1357336872-7200-7-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1357336872-7200-7-git-send-email-ehabkost@redhat.com> Subject: Re: [Qemu-devel] [PATCH qom-cpu 06/11] target-i386: check/enforce: Do not ignore "hypervisor" flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: libvir-list@redhat.com, Igor Mammedov , qemu-devel@nongnu.org, kvm@vger.kernel.org, Andreas =?utf-8?Q?F=C3=A4rber?= On Fri, Jan 04, 2013 at 08:01:07PM -0200, Eduardo Habkost wrote: > We don't need any hack to ignore CPUID_EXT_HYPERVISOR anymore, because > kvm_arch_get_supported_cpuid() now set CPUID_EXT_HYPERVISOR properly. > So, this shouldn't introduce any behavior change, but it makes the code > simpler. > > Signed-off-by: Eduardo Habkost Reviewed-by: Gleb Natapov > --- > My goal is to eliminate the check_feat field completely, as > kvm_arch_get_supported_cpuid() should now really return all the bits we > can set on all CPUID leaves. > --- > target-i386/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index c3e5db8..42c4c99 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -970,7 +970,7 @@ static int kvm_check_features_against_host(x86_def_t *guest_def) > {&guest_def->features, &host_def.features, > ~0, feature_name, 0x00000001, R_EDX}, > {&guest_def->ext_features, &host_def.ext_features, > - ~CPUID_EXT_HYPERVISOR, ext_feature_name, 0x00000001, R_ECX}, > + ~0, ext_feature_name, 0x00000001, R_ECX}, > {&guest_def->ext2_features, &host_def.ext2_features, > ~PPRO_FEATURES, ext2_feature_name, 0x80000001, R_EDX}, > {&guest_def->ext3_features, &host_def.ext3_features, > -- > 1.7.11.7 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Gleb.